Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (5)
- samples/CommunityToolkit.Maui.Sample.sln: Language not supported
- src/CommunityToolkit.Maui.Analyzers.UnitTests/CommunityToolkit.Maui.Analyzers.UnitTests.csproj: Language not supported
- src/CommunityToolkit.Maui.Analyzers.UnitTests/xunit.runner.json: Language not supported
- src/CommunityToolkit.Maui.UnitTests/CommunityToolkit.Maui.UnitTests.csproj: Language not supported
- src/CommunityToolkit.Maui.UnitTests/xunit.runner.json: Language not supported
327bbee to
3582eba
Compare
3582eba to
fb9601d
Compare
2b36717 to
c3cdbbf
Compare
Updated `InitializeServicesAndSetMockApplication` to use `serviceProvider` for setting the Maui context. Removed unnecessary `using` directive and `AnimationManager` property from `HandlersContextStub`, indicating a refactor of animation management functionality.
ne0rrmatrix
left a comment
There was a problem hiding this comment.
This is amazing! I am currently on iteration 28 with zero errors! But the one issue still persisting in tests is line 63 public async Task InvalidValue_InvalidStyle() in ValidationBehaviorTests.cs is failing randomly. My tests have that commented out. If you can figure out that one test failing this PR will be even better. I am waiting for the local run to complete a 1000 round test. I am going to wait to see how it runs but i think this PR is very close to being ready. It is 100 percent better than current tests now. But that one test is still failing randomly.
|
@ne0rrmatrix do you see the test (InvalidValue_InvalidStyle) fails randomly on your local env? |
ne0rrmatrix
left a comment
There was a problem hiding this comment.
This looks great. I am happy with the results of this change. I see a 5X increase in average reliability after extensive testing in local environment.
Uh oh!
There was an error while loading. Please reload this page.