Generate AssemblyInfo from msbuild vs. including in all projects as file #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constant @Arlodotexe is there an issue filed for this somewhere to track?
…url for links in samples Fixes #326
…method used from AssemblyInfo.cs
20 tasks
|
Hmmm... Previous Metadata generation task worked fine on WASM in the CI, but the new fix to move it to This is odd, as I tested on UWP, WinAppSDK, and WASM locally first. I was able to follow the build workflow and reproduce on the command line locally though... will investigate. |
…ration to fix wasm build in CI
Arlodotexe
requested changes
Dec 7, 2022
common/CommunityToolkit.Labs.Shared/Renderers/ToolkitDocumentationRenderer.xaml.cs
Outdated
Show resolved
Hide resolved
common/CommunityToolkit.Labs.Shared/Helpers/PackageProjectUrlAttribute.cs
Show resolved
Hide resolved
Arlodotexe
approved these changes
Dec 8, 2022
Arlodotexe
added a commit
to Avid29/Labs-Windows
that referenced
this pull request
Dec 8, 2022
Arlodotexe
added a commit
to arcadiogarcia/Labs-Windows
that referenced
this pull request
Dec 8, 2022
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
…ssemblymetadata Generate AssemblyInfo from msbuild vs. including in all projects as file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326
This approach removes another file that needs to be duplicated across experiments.
Instead of having hard-coded
Propertes\AssemblyInfo.csfiles, we generate the source for those via an msbuild task,WriteCodeFragmentusingAssemblyAttributes.We do this with the msbuild task and populating the values before the build is setup with a custom target. We can then use reflection at runtime to get our custom assembly attribute which now stores the
PackageProjectUrlfrom the root common props.This will let us store various metadata needed for configuration of our sample app that can work across repositories when we use this infrastructure for the main toolkit.
TODO
x:Bindnot working withFramenavigation unoplatform/uno#2666x:Bindis evaluated too early causing changes inPage.OnNavigatedToto be ignored unoplatform/uno#2872 - moved to constructor)$projectname$type values with the props fromWindows.Toolkit.Common.propsinstead directly?Use this approach forOpened Auto-Generate AdditionalAssemblyInfo.cs file for InternalsVisibleTo #329 for future work trackingInternalVisibleToand removeAdditionalAssemblyInfoas well for library projects?