Skip to content

Conversation

@Arlodotexe
Copy link
Member

This PR fixes an issue where tabs for CanvasLayout were showing when running the ProjectTemplate solution.

closes #116

@Arlodotexe Arlodotexe added the bug 🐛 Something isn't working label May 13, 2022
@Arlodotexe Arlodotexe requested a review from michael-hawker May 13, 2022 19:53
@michael-hawker
Copy link
Member

Following the steps in #116 (building template solution for UWP and then trying to run the WinAppSDK one after) and got this:

3>CSC : error CS0016: Could not write to output file 'H:\code\Labs-UWP\template\lab\samples\ProjectTemplate.WinAppSdk\obj\x64\Debug\net6.0-windows10.0.19041.0\generated\CommunityToolkit.Labs.Core.SourceGenerators\CommunityToolkit.Labs.Core.SourceGenerators.ToolkitSampleMetadataGenerator\ToolkitDocumentRegistry.g.cs' -- 'Could not find a part of the path 'H:\code\Labs-UWP\template\lab\samples\ProjectTemplate.WinAppSdk\obj\x64\Debug\net6.0-windows10.0.19041.0\generated\CommunityToolkit.Labs.Core.SourceGenerators\CommunityToolkit.Labs.Core.SourceGenerators.ToolkitSampleMetadataGenerator\ToolkitDocumentRegistry.g.cs'.'
3>CSC : error CS0016: Could not write to output file 'H:\code\Labs-UWP\template\lab\samples\ProjectTemplate.WinAppSdk\obj\x64\Debug\net6.0-windows10.0.19041.0\generated\CommunityToolkit.Labs.Core.SourceGenerators\CommunityToolkit.Labs.Core.SourceGenerators.ToolkitSampleMetadataGenerator\ToolkitSampleRegistry.g.cs' -- 'Could not find a part of the path 'H:\code\Labs-UWP\template\lab\samples\ProjectTemplate.WinAppSdk\obj\x64\Debug\net6.0-windows10.0.19041.0\generated\CommunityToolkit.Labs.Core.SourceGenerators\CommunityToolkit.Labs.Core.SourceGenerators.ToolkitSampleMetadataGenerator\ToolkitSampleRegistry.g.cs'.'

Doing a git clean and then building then resulted in these errors:

3>CSC : error CS0006: Metadata file 'H:\code\Labs-UWP\common\CommunityToolkit.Labs.Core.SourceGenerators\bin\Debug\netstandard2.0\CommunityToolkit.Labs.Core.SourceGenerators.dll' could not be found
3>CSC : error CS0006: Metadata file 'H:\code\Labs-UWP\common\CommunityToolkit.Labs.Core.SourceGenerators.XamlNamedPropertyRelay\bin\Debug\netstandard2.0\CommunityToolkit.Labs.Core.SourceGenerators.XamlNamedPropertyRelay.dll' could not be found
3>CSC : error CS0006: Metadata file 'H:\code\Labs-UWP\template\lab\samples\ProjectTemplate.Sample\bin\Debug\net6.0-windows10.0.19041.0\ProjectTemplate.Sample.dll' could not be found

Going to go to main and try there and see what happens. We'll also see what happens in the CI as it should be building all these... and the initial commit was fine.

@michael-hawker
Copy link
Member

Not sure what's wrong with my setup. I hit the same issue in main. But then was able to build the all solution fine. It's working for Arlo in the CI. So let's move forward, and we'll see if anyone else hits an issue.

@michael-hawker michael-hawker merged commit 3b654dd into main May 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/canvaslayout-tabs-in-projecttemplate branch May 13, 2022 21:49
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this pull request Sep 2, 2023
…lkit#121)

* Fixed an issue where CanvasLayout markdown flies were picked up by the project template

* Always use wildcard for root exclude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProjectTemplate solution is pulling in CanvasLayout

2 participants