Skip to content

Commit 3c4ef88

Browse files
Test fix for warning suppression
(Didn't realize this PR was still not updated for tooling module, but that does make this fix easier to test...)
1 parent 9b60883 commit 3c4ef88

File tree

4 files changed

+5
-14
lines changed

4 files changed

+5
-14
lines changed

components/TransitionHelper/src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<!-- TODO: Putting here as seems to get flagged on different partials, need to deal with TokenSource being disposible -->
1111
<!-- See: https://github.com/CommunityToolkit/Labs-Windows/issues/407 -->
12-
<NoWarn>CA1001</NoWarn>
12+
<NoWarn>$(NoWarn);CA1001</NoWarn>
1313
</PropertyGroup>
1414

1515
<!-- Sets this up as a toolkit component's source project -->

tooling/MultiTarget/MultiTarget.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
<PropertyGroup>
4242
<!-- These suppressions are for references between generated assemblies and that VS can keep in the Error List once resolved -->
43-
<NoWarn>WMC1006;CS8034;</NoWarn>
43+
<NoWarn>$(NoWarn);WMC1006;CS8034;</NoWarn>
4444
</PropertyGroup>
4545

4646
<ItemGroup>

tooling/MultiTarget/Uno.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
<PackageReference Include="Uno.UI.Skia.Wpf" Version="4.6.18" />
2222
</ItemGroup>
2323
<PropertyGroup Condition="'$(IsWpfHead)' == 'true'">
24-
<!-- Ignorable issue from SkiaSharp package, see: https://github.com/CommunityToolkit/Labs-Windows/pull/119#issuecomment-1125373091 -->
25-
<NoWarn>NU1701</NoWarn>
24+
<!-- NU1701 Ignorable issue from SkiaSharp package, see: https://github.com/CommunityToolkit/Labs-Windows/pull/119#issuecomment-1125373091 -->
25+
<NoWarn>$(NoWarn);NU1701</NoWarn>
2626
</PropertyGroup>
2727

2828
<ItemGroup Condition="'$(IsWasmHead)' == 'true'">

tooling/ProjectHeads/Head.Uwp.props

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
1818
<WindowsXamlEnableOverview>true</WindowsXamlEnableOverview>
1919
<AppxPackageSigningEnabled>false</AppxPackageSigningEnabled>
20+
<NoWarn>$(NoWarn);2008</NoWarn>
2021
</PropertyGroup>
2122

2223
<PropertyGroup Condition="'$(Configuration)' == 'Release'">
@@ -27,19 +28,15 @@
2728
<DebugSymbols>true</DebugSymbols>
2829
<OutputPath>bin\x86\Debug\</OutputPath>
2930
<DefineConstants>$(DefineConstants);DEBUG;TRACE;NETFX_CORE;WINDOWS_UWP</DefineConstants>
30-
<NoWarn>;2008</NoWarn>
3131
<DebugType>full</DebugType>
3232
<PlatformTarget>x86</PlatformTarget>
3333
<UseVSHostingProcess>false</UseVSHostingProcess>
34-
<ErrorReport>prompt</ErrorReport>
35-
<Prefer32Bit>true</Prefer32Bit>
3634
</PropertyGroup>
3735

3836
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x86'">
3937
<OutputPath>bin\x86\Release\</OutputPath>
4038
<DefineConstants>$(DefineConstants);TRACE;NETFX_CORE;WINDOWS_UWP</DefineConstants>
4139
<Optimize>true</Optimize>
42-
<NoWarn>;2008</NoWarn>
4340
<DebugType>pdbonly</DebugType>
4441
<PlatformTarget>x86</PlatformTarget>
4542
<UseVSHostingProcess>false</UseVSHostingProcess>
@@ -51,7 +48,6 @@
5148
<DebugSymbols>true</DebugSymbols>
5249
<OutputPath>bin\ARM\Debug\</OutputPath>
5350
<DefineConstants>$(DefineConstants);DEBUG;TRACE;NETFX_CORE;WINDOWS_UWP</DefineConstants>
54-
<NoWarn>;2008</NoWarn>
5551
<DebugType>full</DebugType>
5652
<PlatformTarget>ARM</PlatformTarget>
5753
<UseVSHostingProcess>false</UseVSHostingProcess>
@@ -63,7 +59,6 @@
6359
<OutputPath>bin\ARM\Release\</OutputPath>
6460
<DefineConstants>$(DefineConstants);TRACE;NETFX_CORE;WINDOWS_UWP</DefineConstants>
6561
<Optimize>true</Optimize>
66-
<NoWarn>;2008</NoWarn>
6762
<DebugType>pdbonly</DebugType>
6863
<PlatformTarget>ARM</PlatformTarget>
6964
<UseVSHostingProcess>false</UseVSHostingProcess>
@@ -75,7 +70,6 @@
7570
<DebugSymbols>true</DebugSymbols>
7671
<OutputPath>bin\ARM64\Debug\</OutputPath>
7772
<DefineConstants>$(DefineConstants);DEBUG;TRACE;NETFX_CORE;WINDOWS_UWP</DefineConstants>
78-
<NoWarn>;2008</NoWarn>
7973
<DebugType>full</DebugType>
8074
<PlatformTarget>ARM64</PlatformTarget>
8175
<UseVSHostingProcess>false</UseVSHostingProcess>
@@ -87,7 +81,6 @@
8781
<OutputPath>bin\ARM64\Release\</OutputPath>
8882
<DefineConstants>$(DefineConstants);TRACE;NETFX_CORE;WINDOWS_UWP</DefineConstants>
8983
<Optimize>true</Optimize>
90-
<NoWarn>;2008</NoWarn>
9184
<DebugType>pdbonly</DebugType>
9285
<PlatformTarget>ARM64</PlatformTarget>
9386
<UseVSHostingProcess>false</UseVSHostingProcess>
@@ -99,7 +92,6 @@
9992
<DebugSymbols>true</DebugSymbols>
10093
<OutputPath>bin\x64\Debug\</OutputPath>
10194
<DefineConstants>$(DefineConstants);DEBUG;TRACE;NETFX_CORE;WINDOWS_UWP</DefineConstants>
102-
<NoWarn>;2008</NoWarn>
10395
<DebugType>full</DebugType>
10496
<PlatformTarget>x64</PlatformTarget>
10597
<UseVSHostingProcess>false</UseVSHostingProcess>
@@ -111,7 +103,6 @@
111103
<OutputPath>bin\x64\Release\</OutputPath>
112104
<DefineConstants>$(DefineConstants);TRACE;NETFX_CORE;WINDOWS_UWP</DefineConstants>
113105
<Optimize>true</Optimize>
114-
<NoWarn>;2008</NoWarn>
115106
<DebugType>pdbonly</DebugType>
116107
<PlatformTarget>x64</PlatformTarget>
117108
<UseVSHostingProcess>false</UseVSHostingProcess>

0 commit comments

Comments
 (0)