Disable warning for CA1001 with disposible in TransitionHelper

michael-hawker · michael-hawker · commit 0b0e1fd689e8 · 2023-03-28T14:48:18.000-07:00
See #407
diff --git a/components/TransitionHelper/src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj b/components/TransitionHelper/src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj
@@ -6,6 +6,10 @@
 
     <!-- Rns suffix is required for namespaces shared across projects. See https://github.com/CommunityToolkit/Labs-Windows/issues/152 -->
     <RootNamespace>CommunityToolkit.Labs.WinUI.TransitionHelperRns</RootNamespace>
+
+    <!-- TODO: Putting here as seems to get flagged on different partials, need to deal with TokenSource being disposible -->
+    <!-- See: https://github.com/CommunityToolkit/Labs-Windows/issues/407 -->
+    <NoWarn>$(NoWarn);CA1001</NoWarn>
   </PropertyGroup>
 
   <!-- Sets this up as a toolkit component's source project -->
diff --git a/components/TransitionHelper/src/TransitionHelper.cs b/components/TransitionHelper/src/TransitionHelper.cs
@@ -10,7 +10,7 @@ namespace CommunityToolkit.Labs.WinUI;
 /// A animation helper that morphs between two controls.
 /// </summary>
 [ContentProperty(Name = nameof(Configs))]
-public sealed partial class TransitionHelper
+public sealed partial class TransitionHelper // TODO: Implement IDisposible? or resolve CA1001 another way?
 {
     private sealed record AnimatedElements<T>(
         IDictionary<string, T> ConnectedElements,

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace CommunityToolkit.Labs.WinUI;`
`10`	`10`	`/// A animation helper that morphs between two controls.`
`11`	`11`	`/// </summary>`
`12`	`12`	`[ContentProperty(Name = nameof(Configs))]`
`13`		`-public sealed partial class TransitionHelper`
	`13`	`+public sealed partial class TransitionHelper // TODO: Implement IDisposible? or resolve CA1001 another way?`
`14`	`14`	`{`
`15`	`15`	`private sealed record AnimatedElements<T>(`
`16`	`16`	`IDictionary<string, T> ConnectedElements,`