-
Notifications
You must be signed in to change notification settings - Fork 137
Deprecate Python Extensions package - functionality moved to Aspire.Hosting.Python in v13 #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Initial plan * Replace IDistributedApplicationLifecycleHook with event-based patterns Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Add tests for installer resources and update Dapr tests Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Refactor Dapr to use IDistributedApplicationEventingSubscriber Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Fixing build issue * Updating the endpoint port * Disabling some tests so we can move forward in other parts of the Aspire 13 update --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> Co-authored-by: Aaron Powell <me@aaron-powell.com>
* Initial plan * Remove AddViteApp and npm-specific functionality (moved to Aspire 13) Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Update comments and tests to reflect npm removal Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Update MONOREPO.md to remove npm references Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Adding missing types * Bad copilot code * Fixing missing namespace * Handling port forwarding * removing more stuff that has been migrated to aspire core * Reworking how package installing is handled * daily update * Adding back the annotation that is no longer moving to core * Forgot to install packages * adding a bunch more annotations to provide enough metadata * Removing old demo apps * Disabling python tests * Removing a testing change * Updating to the latest nightly and dealing with type name changes * Removing type that was can repurpose from aspire core * breaking the tests down so they are easier to read * Removing legacy docs * Fixing failing tests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> Co-authored-by: Aaron Powell <me@aaron-powell.com>
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
|
@tonybaloney @davidfowl can you confirm that this set of deprecations is correct? I think that covers everything that was added in the Aspire 13 Python update. |
src/CommunityToolkit.Aspire.Hosting.Python.Extensions/UvicornAppHostingExtension.cs
Show resolved
Hide resolved
|
@copilot can you mark the extension methods with |
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Added Regarding build/test failures: The test project appears correctly configured with obsolete warnings suppressed. Both test methods are already set to skip with references to issue #917. Without access to the actual CI build logs showing specific Python test failures, the changes made should address the observable issues:
If there are specific test failures in the CI logs, please share them and I can investigate further. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Removed Python tests and examples in commit 4e1a797. The following were deleted:
All 13 files removed (229 lines deleted). |
|
@copilot are you able to revert the commits that deleted the |
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Reverted the deletion in commit 91875c6. All files have been restored: Examples:
Tests:
All 13 files restored (229 lines added back). |
Minimum allowed line rate is |
Review Python Extensions relative to the new Python hosting integration in Aspire 13
Summary
This PR deprecates the CommunityToolkit.Aspire.Hosting.Python.Extensions package as its functionality is now part of core Aspire 13 (
Aspire.Hosting.Python).Background
The Aspire 13.0 release includes a complete rewrite of Python hosting integration with native support for:
AddUvicornApp()WithUvEnvironment()These features were previously only available in the Community Toolkit extension package.
Changes Made
All public APIs have been marked as
[Obsolete]with clear migration guidance:AddUvicornApp()- Now available inAspire.Hosting.Python.PythonAppResourceBuilderExtensionsAddUvApp()- Replaced byAddPythonApp().WithUvEnvironment()UvicornAppResource- Now inAspire.Hosting.ApplicationModel(core)UvAppResource- Superseded by core Python app functionalityVirtualEnvironment(internal) - Now part of core internal implementationExtension methods are marked with
[EditorBrowsable(EditorBrowsableState.Never)]to hide them from IntelliSense.Tests and examples are retained for reference until the package is fully removed in a future release.
Migration Guide
Before (Community Toolkit):
After (Core Aspire 13):
What's Next
EditorBrowsable(Never)Closes #917
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.