Add ability to set JVM args when using executable Java apps #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for passing JVM arguments to executable Java applications in the Community Toolkit. The enhancement allows developers to configure JVM-specific options (like system properties, memory settings, etc.) when using AddJavaApp for executable Java resources.
- Adds
JvmArgsproperty toJavaAppExecutableResourceOptionsclass - Updates executable Java app creation to prepend JVM arguments before the
-jarcommand - Updates test to verify correct argument ordering
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/CommunityToolkit.Aspire.Hosting.Java/JavaAppExecutableResourceOptions.cs |
Adds new JvmArgs property with XML documentation |
src/CommunityToolkit.Aspire.Hosting.Java/JavaAppHostingExtension.Executable.cs |
Implements logic to prepend JVM arguments to command line |
tests/CommunityToolkit.Aspire.Hosting.Java.Tests/ExecutableResourceCreationTests.cs |
Updates test to include JVM args and verify correct argument ordering |
Contributor
Author
|
@dotnet-policy-service agree |
aaronpowell
approved these changes
Oct 12, 2025
This was referenced Nov 4, 2025
Merged
This was referenced Nov 11, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #887
This pull request introduces an additional
JvmArgsproperty toJavaAppExecutableResourceOptionswhich enables passing JVM arguments to executable Java apps when usingAddJavaApp.This is a non-breaking change.
PR Checklist
Other information