Skip to content

Made the DevCertHostingExtensions internal as they're shouldn't be pu… #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

Made the DevCertHostingExtensions internal as they're shouldn't be pu… #854

merged 1 commit into from
Sep 15, 2025

Conversation

@martinjt
Copy link
Contributor

Fixes the accessibility issue flagged in #836

Made DevCertsExtensions internal

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Copilot AI review requested due to automatic review settings September 14, 2025 15:23
Copilot AI reviewed Sep 14, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the DevCertHostingExtensions class internal to fix an accessibility issue by changing the class modifier from public to internal.

  • Changed the accessibility of DevCertHostingExtensions class from public to internal

@aaronpowell aaronpowell merged commit 5d75dd9 into CommunityToolkit:main Sep 15, 2025
103 checks passed
@aaronpowell aaronpowell added this to the 9.8 milestone Sep 24, 2025
This was referenced Sep 26, 2025
Open
Closed
Open
Open
Closed
Open
Closed
FullStackChef pushed a commit to FullStackChef/CommunityToolkit-Aspire that referenced this pull request Sep 26, 2025
@martinjt @FullStackChef
Made the DevCertHostingExtensions internal as they're shouldn't be pu…
77641db 
…blci (CommunityToolkit#854)
This was referenced Sep 29, 2025
Closed
Closed
Merged
Merged
This was referenced Oct 7, 2025
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@davidfowl davidfowl davidfowl approved these changes

@aaronpowell aaronpowell aaronpowell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

9.8

Development

Successfully merging this pull request may close these issues.

3 participants

@martinjt @davidfowl @aaronpowell