-
Notifications
You must be signed in to change notification settings - Fork 131
Adding some more descriptive relationships to the MCP inspector #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the MCP Inspector resource builder by adding more descriptive relationship annotations between inspector and server resources, improving visibility of the inspection relationships in the Aspire dashboard.
- Adds bidirectional relationship annotations with descriptive labels ("Inspected By", "Inspecting", "Default Inspected Server")
- Updates existing tests to verify specific relationship types and directions
- Adds new test case to verify that non-default servers don't get the "Default Inspected Server" relationship
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResourceBuilderExtensions.cs | Adds bidirectional relationships with descriptive labels and conditional default server relationship |
| tests/CommunityToolkit.Aspire.Hosting.McpInspector.Tests/McpInspectorResourceBuilderExtensionsTests.cs | Updates existing test to verify specific relationship types and adds new test for non-default server behavior |
Minimum allowed line rate is |
Contributes to #822