-
Couldn't load subscription status.
- Fork 131
Adding more test coverage and fixing URL handling #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds test coverage for the MCP Inspector integration and fixes URL path handling for server configurations. The changes address URL construction issues where path segments containing slashes were being incorrectly encoded.
- Adds test coverage for resource relationship annotations between MCP Inspector and server resources
- Adds test for custom path segment preservation in MCP server configuration
- Fixes URL combination logic to properly handle multi-segment paths without encoding internal slashes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.McpInspector.Tests/McpInspectorResourceBuilderExtensionsTests.cs | Adds three new test methods covering resource relationships, path preservation, and URL combination logic |
| src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResourceBuilderExtensions.cs | Adds resource relationship annotation and fixes URL path combination to handle multi-segment paths correctly |
...unityToolkit.Aspire.Hosting.McpInspector.Tests/McpInspectorResourceBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
...unityToolkit.Aspire.Hosting.McpInspector.Tests/McpInspectorResourceBuilderExtensionsTests.cs
Show resolved
Hide resolved
Minimum allowed line rate is |
Fixes #822