-
Notifications
You must be signed in to change notification settings - Fork 131
Add Adminer support for SqlServer #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for integrating Adminer with SQL Server resources by introducing the WithAdminer extension method, updating documentation, and adding comprehensive tests.
- Introduces the WithAdminer extension and configures Adminer container resource
- Updates tests for environment variable handling and container configuration
- Enhances example applications and project references to demonstrate the new functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.SqlServer.Extensions.Tests/ResourceCreationTests.cs | Added tests verifying Adminer configuration and annotations |
| tests/CommunityToolkit.Aspire.Hosting.Adminer.Tests/AddAdminerTests.cs | Extended tests to cover integration with multiple SQL Server resources |
| src/CommunityToolkit.Aspire.Hosting.SqlServer.Extensions/SqlServerBuilderExtensions.cs | Introduced the WithAdminer extension method and associated configuration logic |
| src/CommunityToolkit.Aspire.Hosting.SqlServer.Extensions/README.md | Updated documentation to include Adminer support |
| Project and example files | Updated project references and examples demonstrating the new Adminer functionality |
Comments suppressed due to low confidence (1)
src/CommunityToolkit.Aspire.Hosting.SqlServer.Extensions/SqlServerBuilderExtensions.cs:144
- [nitpick] Consider renaming 'new_servers' to 'newServers' to follow standard C# camelCase naming conventions.
var new_servers = sqlServerInstances.ToDictionary(
src/CommunityToolkit.Aspire.Hosting.SqlServer.Extensions/SqlServerBuilderExtensions.cs
Show resolved
Hide resolved
Minimum allowed line rate is |
Contributes to #643
This pull request introduces support for integrating Adminer with SQL Server resources in the
CommunityToolkit.Aspire.Hosting.SqlServer.Extensionspackage. The changes include adding a newWithAdminermethod, updating documentation, and implementing comprehensive tests to validate the functionality.New Feature: Adminer Integration
WithAdminerextension method toSqlServerBuilderExtensionsto enable Adminer as an administration and development platform for SQL Server resources. This includes configuring Adminer containers and managing environment variables for SQL Server instances. [1] [2]SqlServer.Extensionsproject to include a reference to the Adminer project and link theAdminerLoginServershared file.Documentation Updates
README.mdfile inSqlServer.Extensionsto include instructions and examples for using Adminer alongside SQL Server resources. [1] [2]Testing Enhancements
ResourceCreationTests.csto verify the functionality of theWithAdminermethod, including tests for environment variable annotations, container image tags, and multiple SQL Server resources.AddAdminerTests.csto validate Adminer integration with multiple database types. [1] [2] [3]Example Updates
Adminer.AppHostandSqlServer.Extensions.AppHost) to demonstrate the use of theWithAdminermethod for SQL Server resources. [1] [2]Minor Enhancements
System.Text.Jsonreferences in relevant files for handling JSON serialization of Adminer server configurations. (F56fd49aL11R11, tests/CommunityToolkit.Aspire.Hosting.SqlServer.Extensions.Tests/ResourceCreationTests.csR2)PR Checklist
Other information