-
Couldn't load subscription status.
- Fork 131
Add display name for DbGate and Adminer #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display name for DbGate and Adminer #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces display names for DbGate and Adminer dashboards, ensuring that URL annotations include a proper display text.
- Added tests verifying that URL annotations for DbGate and Adminer are correctly applied.
- Updated builder extension methods to include display text for the primary HTTP endpoints.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.DbGate.Tests/AddDbGateTests.cs | Added test to validate DbGate URL annotation with display text "DbGate Dashboard". |
| tests/CommunityToolkit.Aspire.Hosting.Adminer.Tests/AddAdminerTests.cs | Added test to validate Adminer URL annotation with display text "Adminer Dashboard". |
| src/CommunityToolkit.Aspire.Hosting.DbGate/DbGateBuilderExtensions.cs | Updated to add URL annotation with display text "DbGate Dashboard" for DbGate endpoints. |
| src/CommunityToolkit.Aspire.Hosting.Adminer/AdminerBuilderExtensions.cs | Updated to add URL annotation with display text "Adminer Dashboard" for Adminer endpoints. |
Comments suppressed due to low confidence (1)
tests/CommunityToolkit.Aspire.Hosting.DbGate.Tests/AddDbGateTests.cs:470
- [nitpick] The test method name 'AddAddDbGateWithDefaultsAddsUrlAnnotations' has a duplicate 'Add'. Consider renaming it to 'AddDbGateWithDefaultsAddsUrlAnnotations' for consistency.
public async Task AddAddDbGateWithDefaultsAddsUrlAnnotations()
Minimum allowed line rate is |
Fixes #642