Update Aspire version to 9.2.0 #627
Conversation
MackinnonBuck
requested review from
ErikEJ,
esskar,
jmezach and
justinyoo
as code owners
|
Looks like we've got some behaviour changes in a few parts for 9.2 that we need to resolve |
|
Fixed some of the tests, but will need to get @FullStackChef to have a look at the outstanding Azure Dapr Redis tests that are failing. I think that we are hitting this breaking change in the release and is resulting in the failure, but I'm not familiar enough with the code to know what the right fix should be. |
|
@aaronpowell Can this target a 9.2 upgrade branch so I can chuck a PR up against it please |
You can check out and push to this branch as it's setup for contributors to contribute to it. I find the easiest way is to use the VS Code GitHub PR extension to checkout the PR, as that will setup the remote and everything for you. |
Update tests to remove principal information
|
@FullStackChef with the change we no longer assert that auth part is in the bicep, do we need to assert that? Or was the inclusion of that more of a byproduct of how the old implementation of the Aspire Redis integration worked with Azure? |
|
@aaronpowell, Could you take a look at the changes in Redis-Dbgate stuffs? |
Looks all good. I think we should be fine to cut the release, unless there's anything else we want to get into 9.4 |
There is nothing on my side. Let's cut the release. |
|
I'll try and do it tonight, back to work in a few days, so worst case it'll be then (or you should be able to push a tag @Alirexaa ) |
|
@aaronpowell fyi I have tested the redis integration via an actual deployment. It seems to be working... |
|
@aaronpowell, I can push a tag now. |
|
@aaronpowell, a new tag has been pushed. I need approval for the |
Seems GitHub mobile app doesn't have a way to approve, I'll jump on a PC tonight and do it |
4 participants
No description provided.