Comment out unstable DisplayOrder in annotations #1088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment out DisplayOrder assignments for stability.
10 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses instability in the Aspire API by commenting out the DisplayOrder property assignments for MCP Inspector endpoint annotations. The change references a GitHub issue tracking the API instability and includes explanatory comments for future restoration.
- Commented out
DisplayOrderassignments for Client and Server Proxy endpoint annotations - Added detailed comments explaining the reasoning and linking to the upstream issue
src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…esourceBuilderExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aaronpowell
approved these changes
Jan 12, 2026
This was referenced Jan 14, 2026
Bump CommunityToolkit.Aspire.Hosting.Flagd from 13.0.0 to 13.1.0
askpt/openfeature-aspire-sample#270
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the
AddMcpInspectorextension method inMcpInspectorResourceBuilderExtensions.cs. The change removes the use of theDisplayOrderproperty for endpoint annotations due to instability in the Aspire API, and adds comments explaining the reasoning and future plans.Endpoint annotation adjustments:
annotation.DisplayOrderfor bothClientandServer Proxyendpoints, with explanatory comments referencing the instability in Aspire and a related GitHub issue. (src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResourceBuilderExtensions.cs, src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResourceBuilderExtensions.csL95-R105)Comment out DisplayOrder assignments for stability.