Doc best practices/expected usage for default vite app port

[maddymontaquila]

Page URL

https://learn.microsoft.com/en-us/dotnet/aspire/community-toolkit/hosting-nodejs-extensions?tabs=dotnet-cli%2Cyarn#run-vite-apps

Describe the issue

Vite defaults their dev server to port 5173 (and then increments it if its taken) - when you follow the docs there is no guidance about setting targetPort or anything. The default endpoint handled by Aspire spins forever then fails because it doesn't point to 5173 (which works fine) -

var frontend = builder.AddViteApp("frontend", "../frontend", packageManager: "pnpm")
    .WithPnpmPackageInstallation()
    .WithReference(ratingsApi)
    .WithExternalHttpEndpoints();

Suggestion

We should either handle that in the Vite extension by default or add
.WithHttpEndpoint(targetPort: 5173)
to the docs.

Additional context

No response

Help us help you

No, just wanted to report this

[github-actions]

We have noticed this issue has not been updated within 21 days. If there is no action on this issue in the next 14 days, we will automatically close it. You can use /stale-extend to extend the window.

[aaronpowell]

With #724 being merged and it having better handling of the port setting (requiring no change in the Vite app) - can you review with the latest beta package @maddymontaquila if there is still ambiguity in our docs?

[maddymontaquila]

Latest change didn't work for me -

so cant verify this yet :D

[aaronpowell]

Which version of the extensions package were you using? The changes are in the 9.5.1-beta.* releases

[TWolversonReply]

Works for me with beta.311, if that helps:

The source command line displayed has changed to something that looks a tad strange but I presume must be right, as I can now browse on this port.

[github-actions]

We have noticed this issue has not been updated within 21 days. If there is no action on this issue in the next 14 days, we will automatically close it. You can use /stale-extend to extend the window.

[github-actions]

This issue has been stale for 5 weeks and has been automatically closed.