Skip to content

Commit f16b0f3

Browse files
Copilotdavidfowl
andcommitted
Apply IValueProvider cast pattern for GetValueAsync calls as requested
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
1 parent 48a452e commit f16b0f3

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/CommunityToolkit.Aspire.Hosting.ActiveMQ/ActiveMQBuilderExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ private static IResourceBuilder<T> WithJolokiaHealthCheck<T>(
177177
{
178178
Uri baseUri = new Uri(endpoint.Url, UriKind.Absolute);
179179
string userName = (await builder.Resource.UserNameReference.GetValueAsync(ct))!;
180-
string password = (await builder.Resource.PasswordParameter.GetValueAsync(ct))!;
180+
string password = (await ((IValueProvider)builder.Resource.PasswordParameter).GetValueAsync(ct))!;
181181
basicAuthentication = "Basic " + Convert.ToBase64String(Encoding.UTF8.GetBytes($"{userName}:{password}"));
182182
uri = new UriBuilder(baseUri)
183183
{

tests/CommunityToolkit.Aspire.Hosting.DbGate.Tests/AddDbGateTests.cs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using System.Net.Sockets;
22
using Aspire.Components.Common.Tests;
33
using Aspire.Hosting;
4+
using Aspire.Hosting.ApplicationModel;
45
using Aspire.Hosting.Utils;
56

67
namespace CommunityToolkit.Aspire.Hosting.DbGate.Tests;
@@ -298,7 +299,7 @@ public async Task WithDbGateShouldAddAnnotationsForMultipleDatabaseTypes()
298299
async item =>
299300
{
300301
Assert.Equal("PASSWORD_postgres1", item.Key);
301-
var expectedPassword = await postgresResource1.PasswordParameter.GetValueAsync(default);
302+
var expectedPassword = await ((IValueProvider)postgresResource1.PasswordParameter).GetValueAsync(default);
302303
Assert.Equal(expectedPassword, item.Value);
303304
},
304305
item =>
@@ -329,7 +330,7 @@ public async Task WithDbGateShouldAddAnnotationsForMultipleDatabaseTypes()
329330
async item =>
330331
{
331332
Assert.Equal("PASSWORD_postgres2", item.Key);
332-
var expectedPassword = await postgresResource2.PasswordParameter.GetValueAsync(default);
333+
var expectedPassword = await ((IValueProvider)postgresResource2.PasswordParameter).GetValueAsync(default);
333334
Assert.Equal(expectedPassword, item.Value);
334335
},
335336
item =>
@@ -350,7 +351,7 @@ public async Task WithDbGateShouldAddAnnotationsForMultipleDatabaseTypes()
350351
async item =>
351352
{
352353
var expectedRedisUrl = redisResource1.PasswordParameter is not null ?
353-
$"redis://:{await redisResource1.PasswordParameter.GetValueAsync(default)}@{redisResource1.Name}:{redisResource1.PrimaryEndpoint.TargetPort}" : $"redis://{redisResource1.Name}:{redisResource1.PrimaryEndpoint.TargetPort}";
354+
$"redis://:{await ((IValueProvider)redisResource1.PasswordParameter).GetValueAsync(default)}@{redisResource1.Name}:{redisResource1.PrimaryEndpoint.TargetPort}" : $"redis://{redisResource1.Name}:{redisResource1.PrimaryEndpoint.TargetPort}";
354355
Assert.Equal("URL_redis1", item.Key);
355356
Assert.Equal(expectedRedisUrl, item.Value);
356357
},
@@ -367,7 +368,7 @@ public async Task WithDbGateShouldAddAnnotationsForMultipleDatabaseTypes()
367368
async item =>
368369
{
369370
var expectedRedisUrl = redisResource2.PasswordParameter is not null ?
370-
$"redis://:{await redisResource2.PasswordParameter.GetValueAsync(default)}@{redisResource2.Name}:{redisResource2.PrimaryEndpoint.TargetPort}" : $"redis://{redisResource2.Name}:{redisResource2.PrimaryEndpoint.TargetPort}";
371+
$"redis://:{await ((IValueProvider)redisResource2.PasswordParameter).GetValueAsync(default)}@{redisResource2.Name}:{redisResource2.PrimaryEndpoint.TargetPort}" : $"redis://{redisResource2.Name}:{redisResource2.PrimaryEndpoint.TargetPort}";
371372
Assert.Equal("URL_redis2", item.Key);
372373
Assert.Equal(expectedRedisUrl, item.Value);
373374
},
@@ -394,7 +395,7 @@ public async Task WithDbGateShouldAddAnnotationsForMultipleDatabaseTypes()
394395
async item =>
395396
{
396397
Assert.Equal("PASSWORD_sqlserver1", item.Key);
397-
var expectedPassword = await sqlserverResource1.PasswordParameter.GetValueAsync(default);
398+
var expectedPassword = await ((IValueProvider)sqlserverResource1.PasswordParameter).GetValueAsync(default);
398399
Assert.Equal(expectedPassword, item.Value);
399400
},
400401
item =>
@@ -425,7 +426,7 @@ public async Task WithDbGateShouldAddAnnotationsForMultipleDatabaseTypes()
425426
async item =>
426427
{
427428
Assert.Equal("PASSWORD_sqlserver2", item.Key);
428-
var expectedPassword = await sqlserverResource2.PasswordParameter.GetValueAsync(default);
429+
var expectedPassword = await ((IValueProvider)sqlserverResource2.PasswordParameter).GetValueAsync(default);
429430
Assert.Equal(expectedPassword, item.Value);
430431
},
431432
item =>
@@ -456,7 +457,7 @@ public async Task WithDbGateShouldAddAnnotationsForMultipleDatabaseTypes()
456457
async item =>
457458
{
458459
Assert.Equal("PASSWORD_mysql1", item.Key);
459-
var expectedPassword = await mysqlResource1.PasswordParameter.GetValueAsync(default);
460+
var expectedPassword = await ((IValueProvider)mysqlResource1.PasswordParameter).GetValueAsync(default);
460461
Assert.Equal(expectedPassword, item.Value);
461462
},
462463
item =>
@@ -487,7 +488,7 @@ public async Task WithDbGateShouldAddAnnotationsForMultipleDatabaseTypes()
487488
async item =>
488489
{
489490
Assert.Equal("PASSWORD_mysql2", item.Key);
490-
var expectedPassword = await mysqlResource2.PasswordParameter.GetValueAsync(default);
491+
var expectedPassword = await ((IValueProvider)mysqlResource2.PasswordParameter).GetValueAsync(default);
491492
Assert.Equal(expectedPassword, item.Value);
492493
},
493494
item =>

0 commit comments

Comments
 (0)