Refactor logging configuration: replace WithLogging method with WithLogLevel for improved clarity and functionality

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Author: askpt

examples/flagd/CommunityToolkit.Aspire.Hosting.Flagd.AppHost/Program.cs

@@ -6,6 +6,6 @@
 var flagd = builder
     .AddFlagd("flagd")
     .WithBindFileSync("./flags/")
-    .WithLogging();
+    .WithLogLevel(Microsoft.Extensions.Logging.LogLevel.Debug);
 
 builder.Build().Run();

src/CommunityToolkit.Aspire.Hosting.Flagd/FlagdBuilderExtensions.cs

@@ -43,19 +43,6 @@ public static IResourceBuilder<FlagdResource> AddFlagd(
             .WithArgs("start");
     }
 
-    /// <summary>
-    /// Configures logging level for flagd. If a flag or targeting rule isn't proceeding the way you'd expect this can be enabled to get more verbose logging.
-    /// </summary>
-    /// <param name="builder">The resource builder.</param>
-    /// <returns>The <see cref="IResourceBuilder{FlagdResource}"/>.</returns>
-    public static IResourceBuilder<FlagdResource> WithLogging(
-        this IResourceBuilder<FlagdResource> builder)
-    {
-        ArgumentNullException.ThrowIfNull(builder, nameof(builder));
-
-        return builder.WithEnvironment("FLAGD_DEBUG", "true");
-    }
-
     /// <summary>
     /// Configures logging level for flagd. If a flag or targeting rule isn't proceeding the way you'd expect this can be enabled to get more verbose logging.
     /// </summary>
@@ -64,7 +51,7 @@ public static IResourceBuilder<FlagdResource> WithLogging(
     /// <returns>The <see cref="IResourceBuilder{FlagdResource}"/>.</returns>
     /// <exception cref="InvalidOperationException">Thrown if the log level is not valid.</exception>
     /// <remarks>Currently only debug is supported.</remarks>
-    public static IResourceBuilder<FlagdResource> WithLoglevel(
+    public static IResourceBuilder<FlagdResource> WithLogLevel(
         this IResourceBuilder<FlagdResource> builder,
         LogLevel logLevel)
     {

tests/CommunityToolkit.Aspire.Hosting.Flagd.Tests/AddFlagdTests.cs

@@ -136,26 +136,11 @@ public void AddFlagdAddsStartArgument()
         Assert.NotEmpty(commandLineArgs);
     }
 
-    [Fact]
-    public void WithLoggingAddsEnvironmentVariable()
-    {
-        var builder = DistributedApplication.CreateBuilder();
-        builder.AddFlagd(FlagdName).WithLogging();
-
-        using var app = builder.Build();
-
-        var appModel = app.Services.GetRequiredService<DistributedApplicationModel>();
-        var resource = Assert.Single(appModel.Resources.OfType<FlagdResource>());
-
-        var envAnnotations = resource.Annotations.OfType<EnvironmentCallbackAnnotation>().ToArray();
-        Assert.NotEmpty(envAnnotations);
-    }
-
     [Fact]
     public void WithLoglevelDebugAddsEnvironmentVariable()
     {
         var builder = DistributedApplication.CreateBuilder();
-        builder.AddFlagd(FlagdName).WithLoglevel(Microsoft.Extensions.Logging.LogLevel.Debug);
+        builder.AddFlagd(FlagdName).WithLogLevel(Microsoft.Extensions.Logging.LogLevel.Debug);
 
         using var app = builder.Build();
 
@@ -178,7 +163,7 @@ public void WithLoglevelThrowsForUnsupportedLogLevels(Microsoft.Extensions.Loggi
         var builder = DistributedApplication.CreateBuilder();
         var flagd = builder.AddFlagd(FlagdName);
 
-        var exception = Assert.Throws<InvalidOperationException>(() => flagd.WithLoglevel(logLevel));
+        var exception = Assert.Throws<InvalidOperationException>(() => flagd.WithLogLevel(logLevel));
         Assert.Equal("Only debug log level is supported", exception.Message);
     }
 
@@ -187,7 +172,7 @@ public void WithLoglevelThrowsWhenBuilderIsNull()
     {
         IResourceBuilder<FlagdResource> builder = null!;
 
-        Assert.Throws<ArgumentNullException>(() => builder.WithLoglevel(Microsoft.Extensions.Logging.LogLevel.Debug));
+        Assert.Throws<ArgumentNullException>(() => builder.WithLogLevel(Microsoft.Extensions.Logging.LogLevel.Debug));
     }
 
     [Fact]
@@ -281,14 +266,6 @@ public void AddFlagdThrowsWhenBuilderIsNull()
         Assert.Throws<ArgumentNullException>(() => builder.AddFlagd(FlagdName));
     }
 
-    [Fact]
-    public void WithLoggingThrowsWhenBuilderIsNull()
-    {
-        IResourceBuilder<FlagdResource> builder = null!;
-
-        Assert.Throws<ArgumentNullException>(() => builder.WithLogging());
-    }
-
     [Fact]
     public void WithBindFileSyncThrowsWhenBuilderIsNull()
     {