Remove automatic WithExternalHttpEndpoints from AddViteApp to let users decide

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

Author: Copilot

src/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions/NodeJSHostingExtensions.cs

@@ -38,8 +38,8 @@ public static IResourceBuilder<NodeAppResource> AddViteApp(this IDistributedAppl
         };
 
         _ = useHttps
-            ? resource.WithHttpsEndpoint(env: "PORT").WithExternalHttpEndpoints()
-            : resource.WithHttpEndpoint(env: "PORT").WithExternalHttpEndpoints();
+            ? resource.WithHttpsEndpoint(env: "PORT")
+            : resource.WithHttpEndpoint(env: "PORT");
 
         return resource.WithArgs(ctx =>
         {

tests/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.Tests/ResourceCreationTests.cs

@@ -139,7 +139,7 @@ public void ViteAppHasExposedHttpsEndpoints()
 
 
     [Fact]
-    public void ViteAppHasExposedExternalHttpEndpoints()
+    public void ViteAppDoesNotExposeExternalHttpEndpointsByDefault()
     {
         var builder = DistributedApplication.CreateBuilder();
 
@@ -155,7 +155,7 @@ public void ViteAppHasExposedExternalHttpEndpoints()
 
         Assert.True(resource.TryGetAnnotationsOfType<EndpointAnnotation>(out var endpoints));
 
-        Assert.Contains(endpoints, e => e.IsExternal);
+        Assert.DoesNotContain(endpoints, e => e.IsExternal);
     }
 
     [Fact]