Set id's on plugin data #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @rubenvdlinde
|
rjzondervan
previously approved these changes
Jan 18, 2023
WilcoLouwerse
requested changes
Jan 18, 2023
Service/RequestService.php
Outdated
| @@ -547,7 +548,7 @@ public function requestHandler(array $data, array $configuration): Response | |||
|
|
|||
| $this->handleMetadataSelf($result, $metadataSelf); | |||
|
|
|||
| $result = $this->shouldWeUnsetEmbedded($result, $this->data['headers']['accept'] ?? null, $isCollection ?? false); | |||
| // $result = $this->shouldWeUnsetEmbedded($result, $this->data['headers']['accept'] ?? null, $isCollection ?? false); | |||
There was a problem hiding this comment.
Dit willen we volgensmij alleen voor kiss doen en niet op master.
Dit zorgt dat we altijd embedded tonen namelijk.
Waar, al dus Barry, we voor roxit deze functie gebruiken en alleen voor accept header json+ld embedded tonen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the id or _id properties on plugin data to set the id on object entities