Skip to content

Commit 7dee4e1

Browse files
fix: address reviewer feedback on cache optimization PR (#5200)
* fix: remove duplicate cache entries and fix YAML formatting - Remove duplicate path entries in dev-release.yaml - Remove redundant node_modules/.cache entries since setup-node handles npm caching - Fix YAML indentation issues across workflow files Addresses reviewer feedback on PR #5117 about duplication and maintenance * fix: add cache-dependency-path for setup-node in test-ui workflow The test-ui workflow runs at repo root but package-lock.json is in ComfyUI_frontend/ subdirectory, causing setup-node cache to fail. Added cache-dependency-path to fix this.
1 parent b97870d commit 7dee4e1

File tree

8 files changed

+1
-11
lines changed

8 files changed

+1
-11
lines changed

.github/workflows/chromatic.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ jobs:
5656
with:
5757
path: |
5858
.cache
59-
node_modules/.cache
6059
storybook-static
6160
tsconfig.tsbuildinfo
6261
key: storybook-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('src/**/*.{ts,vue,js}', '*.config.*', '.storybook/**/*') }}

.github/workflows/dev-release.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,7 @@ jobs:
2727
path: |
2828
.cache
2929
dist
30-
node_modules/.cache
3130
tsconfig.tsbuildinfo
32-
.cache
33-
tsconfig.tsbuildinfo
34-
dist
3531
key: dev-release-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
3632
restore-keys: |
3733
dev-release-tools-cache-${{ runner.os }}-

.github/workflows/i18n.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ jobs:
2323
with:
2424
path: |
2525
ComfyUI_frontend/.cache
26-
ComfyUI_frontend/node_modules/.cache
2726
ComfyUI_frontend/.cache
2827
key: i18n-tools-cache-${{ runner.os }}-${{ hashFiles('ComfyUI_frontend/package-lock.json') }}
2928
restore-keys: |

.github/workflows/release.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ jobs:
2828
uses: actions/cache@v4
2929
with:
3030
path: |
31-
node_modules/.cache
3231
.cache
3332
tsconfig.tsbuildinfo
3433
key: release-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
@@ -136,7 +135,6 @@ jobs:
136135
uses: actions/cache@v4
137136
with:
138137
path: |
139-
node_modules/.cache
140138
.cache
141139
tsconfig.tsbuildinfo
142140
dist

.github/workflows/test-ui.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ jobs:
4141
with:
4242
node-version: lts/*
4343
cache: 'npm'
44+
cache-dependency-path: 'ComfyUI_frontend/package-lock.json'
4445

4546
- name: Get current time
4647
id: current-time

.github/workflows/update-electron-types.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ jobs:
2525
with:
2626
path: |
2727
.cache
28-
node_modules/.cache
2928
key: electron-types-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
3029
restore-keys: |
3130
electron-types-tools-cache-${{ runner.os }}-

.github/workflows/update-manager-types.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ jobs:
2929
uses: actions/cache@v4
3030
with:
3131
path: |
32-
node_modules/.cache
3332
.cache
3433
key: update-manager-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
3534
restore-keys: |

.github/workflows/update-registry-types.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ jobs:
2929
with:
3030
path: |
3131
.cache
32-
node_modules/.cache
3332
key: update-registry-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
3433
restore-keys: |
3534
update-registry-tools-cache-${{ runner.os }}-

0 commit comments

Comments
 (0)