Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong display when no content #5636

Closed
Safranil opened this issue Jul 15, 2024 · 7 comments
Closed

[BUG] Wrong display when no content #5636

Safranil opened this issue Jul 15, 2024 · 7 comments
Labels
Milestone

Comments

@Safranil
Copy link

Describe the bug
When the content in main.app-main is not long enough or without explicit size, the layout is broken on small screen.

After some digging, this is because .app-wrapper have grid-template-columns: auto 1fr;, the auto get the content size wrong in this case.

Patch

.app-main-wrapper {
  @include media-breakpoint-down(lg) {
    width: 100vw;
  }
}

Screenshots
Before the patch:
image

After the patch:
image

Environment (please complete the following information):

  • AdminLTE Version: 4.0.0-beta1
  • Operating System: Debian 12
  • Browser (Version): Firefox 115.13.0 ESR
@danny007in
Copy link
Collaborator

can you create PR for this if possible

@danny007in danny007in added this to the v4.0.0 milestone Aug 24, 2024
@danny007in
Copy link
Collaborator

i am unable to rectify error can you please provide html source of it

@danny007in
Copy link
Collaborator

https://app.netlify.com/sites/adminlte-v4/deploys
in preview which page can i get this error

@jongbonga
Copy link

@danny007in I get the same issue on with fixed complete layout.
When sidebarBreakpoint < 992, with no or little content.

You can reproduce here by closing the accordion

Screenshot 2024-08-29 at 01 02 21 Screenshot 2024-08-29 at 01 04 01

@danny007in
Copy link
Collaborator

issue clear v4.0.0-beta2

@jongbonga
Copy link

issue clear v4.0.0-beta2

Should we replace the fixed layout with the custom-area layout instead?

@danny007in
Copy link
Collaborator

issue clear v4.0.0-beta2

Should we replace the fixed layout with the custom-area layout instead?

please replace with fixed sidebar layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants