[BUG] Move CSS outside of JS

[XhmikosR]

I mark it as a bug, because it reduces performance. It's faster to add/remove a CSS class than setting/getting CSS properties via jQuery.

Now, this should wait a bit after I'm done with my refactoring PRs, should be done in the next 2 days. After that, this issue should be tackled.

This, but most importantly #2719, along with any JS refactoring, should really make things much more performant. :)

PS. Is the next version going to be a minor release? Do you follow semver properly? Because dropping IE 10 support is a breaking change, for example. But on the other hand, we could narrow the supported browsers in .browserslistrc and thus reduce the CSS size too.

[REJack]

Is the next version going to be a minor release?

You mean with all your currently merged changes?

Do you follow semver properly?

I would say to 80% 🤣

Because dropping IE 10 support is a breaking change, for example.

Where we dropped IE10 Support? :)

[XhmikosR]

You mean with all your currently merged changes?

Yeah, so that I know what kind of changes I can make.

Where we dropped IE10 Support? :)

Nowhere, but I thought you planned to drop it. :)

[REJack]

Yeah, so that I know what kind of changes I can make.

At the moment I would create only a patch version and then I planned to start with a minor version (v3.1) with all the open issues in it.

Nowhere, but I thought you planned to drop it. :)

I would drop IE10 with the next major Bootstrap version (v5)

[REJack]

I'll test later all the changes and publish AdminLTE v3.0.6 (you only added ESLint & StyleLint for this I wouldn't create a minor version 😃 I fixed only small stuff and update the docs), then you can create your next changes for the next minor version and I will do all the open v3.1.0 issues 😄.

[XhmikosR]

I think we could land some more stuff. But I wouldn't make it a patch release personally. There have been too many changes

[REJack]

Since we only fixed one small issue and only you have reported it we could directly move on to develop v3.1 and I'll start with the first changes.