Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor existing performance test #16

Open
hectorjsmith opened this issue Jun 12, 2020 · 0 comments
Open

Refactor existing performance test #16

hectorjsmith opened this issue Jun 12, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hectorjsmith
Copy link
Collaborator

Requirement

Refactor the existing performance test (TestGivenArrayWithLargeNumberOfElementsWhenCheckForDuplicatesThenCheckIsFast) to ensure its result is deterministic and not based on chance.

Another option is to simply remove this test.

Once this test is resolved, test categories can be removed from all other tests. Since all other tests have the same category the categories serve no purpose.

Value Proposition

There are two main issues with the existing performance test:

  1. It is a manual test - This means the user has to manually inspect the output of the test
  2. Its result can vary based on factors not related to the code itself (e.g. the processing speed of the machine it runs on)

Design Ideas

The simplest solution is to remove the test. But there may be value in having this test to ensure that performance does not suffer.

If the test is to stay, it should be refactored to fix the two issues above.

This issue requires further discussion

@hectorjsmith hectorjsmith added enhancement New feature or request help wanted Extra attention is needed labels Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant