chore: updated deprecations and removed older obsolete methods

Author: Lachee

DiscordRPC/DiscordRpcClient.cs

@@ -716,13 +716,6 @@ public bool RegisterUriScheme(string steamAppID = null, string executable = null
         /// <param name="type">The event type to subscribe to</param>
         public void Subscribe(EventType type) { SetSubscription(Subscription | type); }
 
-        /// <summary>
-        /// 
-        /// </summary>
-        /// <param name="type"></param>
-        [System.Obsolete("Replaced with Unsubscribe", true)]
-        public void Unubscribe(EventType type) { SetSubscription(Subscription & ~type); }
-
         /// <summary>
         /// Unsubscribe from the event sent by discord. Used for Join / Spectate feature.
         /// <para>Requires the UriScheme to be registered.</para>

DiscordRPC/Entities/RichPresence.cs

@@ -125,17 +125,16 @@ public string DetailsUrl
         /// </summary>
         [JsonProperty("status_display_type", NullValueHandling = NullValueHandling.Ignore)]
         public StatusDisplayType StatusDisplay { get; set; }
-        
+
 
         /// <summary>
         /// Marks the <see cref="Secrets.MatchSecret"/> as a game session with a specific beginning and end. It was going to be used as a form of notification, but was replaced with the join feature. It may potentially have use in the future, but it currently has no use.
         /// <para>
         /// "TLDR it marks the matchSecret field as an instance, that is to say a context in game that’s not like a lobby state/not in game state. It was gonna he used for notify me, but we scrapped that for ask to join. We may put it to another use in the future. For now, don’t worry about it" - Mason (Discord API Server 14 / 03 / 2018)
         ///    </para>
         /// </summary>
-        [JsonProperty("instance", NullValueHandling = NullValueHandling.Ignore)]
-        [Obsolete("This was going to be used, but was replaced by JoinSecret instead")]
-        private bool Instance { get; set; }
+        [Obsolete("This was going to be used, but was replaced by JoinSecret instead", true)]
+        private bool Instance;
 
         #region Has Checks
         /// <summary>
@@ -237,7 +236,6 @@ public static implicit operator bool(BaseRichPresence presence)
         /// <returns></returns>
         internal virtual bool Matches(RichPresence other)
         {
-#pragma warning disable CS0618 // Type or member is obsolete
             if (other == null)
                 return false;
 
@@ -266,7 +264,6 @@ internal virtual bool Matches(RichPresence other)
             {
                 if (other.Secrets == null ||
                     other.Secrets.JoinSecret != Secrets.JoinSecret ||
-                    other.Secrets.MatchSecret != Secrets.MatchSecret ||
                     other.Secrets.SpectateSecret != Secrets.SpectateSecret)
                     return false;
             }
@@ -307,8 +304,7 @@ internal virtual bool Matches(RichPresence other)
                 return false;
             }
 
-            return Instance == other.Instance;
-#pragma warning restore CS0618 // Type or member is obsolete
+            return true;
         }
 
         /// <summary>

DiscordRPC/Entities/Secrets.cs

@@ -19,18 +19,8 @@ public class Secrets
 		/// <para>This cannot be null and must be supplied for the  Join / Spectate feature to work.</para>
 		/// <para>Max Length of 128 characters</para>
 		/// </summary>
-		[Obsolete("This feature has been deprecated my Mason in issue #152 on the offical library. Was originally used as a Notify Me feature, it has been replaced with Join / Spectate.")]
-		[JsonProperty("match", NullValueHandling = NullValueHandling.Ignore)]
-		public string MatchSecret
-		{
-			get { return _matchSecret; }
-			set
-			{
-				if (!BaseRichPresence.ValidateString(value, out _matchSecret, false, 128))
-					throw new StringOutOfRangeException(128);
-			}
-		}
-		private string _matchSecret;
+		[Obsolete("This feature has been deprecated my Mason in issue #152 on the offical library. Was originally used as a Notify Me feature, it has been replaced with Join / Spectate.", true)]
+		public string MatchSecret;
 
 		/// <summary>
 		/// The secret data that will tell the client how to connect to the game to play. This could be a unique identifier for a fancy match maker or player id, lobby id, etc.

DiscordRPC/Logging/ConsoleLogger.cs

@@ -23,7 +23,6 @@ public class ConsoleLogger : ILogger
 		/// <summary>
 		/// A alias too <see cref="Coloured"/>
 		/// </summary>
-		[System.Obsolete("Use Coloured")]
 		public bool Colored {
 			get => Coloured;
 			set => Coloured = value;