feat: bearer auth #111
Open
feat: bearer auth #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscha
commented
Feb 27, 2025
| @@ -39,8 +39,13 @@ Before creating an issue please make sure that it was not already reported. | |||
| #### Code | |||
|
|
|||
| 1) Create a new branch based on `develop` branch. | |||
| * Optional: create and enable virtualenv: | |||
There was a problem hiding this comment.
I used a virtualenv here as I didn't want to pollute my local machine with extra packages. Thought it might be useful for others, too.
joscha
commented
Feb 27, 2025
| 2) Fetch all dev dependencies. | ||
| * Install required python modules using `pip`: **python -m pip install .[testing]** | ||
| * Install required python modules using `pip`: **python -m pip install ".[testing]"** |
There was a problem hiding this comment.
my shell (zsh) didn't like the [ and ] without quoting them.
joscha
commented
Feb 27, 2025
| @@ -43,6 +43,7 @@ issues = "https://github.com/Colin-b/httpx_auth/issues" | |||
|
|
|||
| [project.optional-dependencies] | |||
| testing = [ | |||
| "pytest==8.3.4", | |||
There was a problem hiding this comment.
I am not sure why this was missing here, I assume it comes with pytest-cov in whatever version is deemed suitable there.
joscha
commented
Feb 27, 2025
| @@ -55,12 +56,15 @@ testing = [ | |||
| "pytest-asyncio==0.25.*", | |||
| ] | |||
|
|
|||
| [tool.setuptools] | |||
| py-modules = [ | |||
| "httpx_auth" | |||
There was a problem hiding this comment.
this is needed for:
Processing /Users/joscha/dev/httpx_auth
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [93 lines of output]
No `packages` or `py_modules` configuration, performing automatic discovery.
`flat-layout` detected -- analysing .
discovered packages -- ['httpx_auth', 'myenv', 'httpx_auth._oauth2', 'myenv.bin', 'myenv.include', 'myenv.lib']
possibly related to the virtualenv?
joscha
commented
Feb 27, 2025
| @@ -0,0 +1,3 @@ | |||
| [pytest] | |||
| asyncio_mode = auto | |||
There was a problem hiding this comment.
Without this, I get:
INTERNALERROR> pytest.PytestConfigWarning: Unknown config option: asyncio_default_fixture_loop_scope
joscha
commented
Feb 27, 2025
joscha
commented
Feb 27, 2025
joscha
commented
Feb 27, 2025
joscha
commented
Feb 27, 2025
| @@ -0,0 +1,3 @@ | |||
| [pytest] | |||
| asyncio_mode = auto | |||
| asyncio_default_fixture_loop_scope = "function" | |||
|
|
^ ping @Colin-b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a very simple Bearer authentication class.
Happy to add docs, if accepted.