Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mappings are not applied to currently open files (4.0.0-SNAPSHOT) #861

Open
solonovamax opened this issue Sep 27, 2024 · 3 comments
Open
Labels
4.X Missing details Needs more info to understand the problem

Comments

@solonovamax
Copy link

Describe the bug

When applying mappings, the currently open files are not remapped

To Reproduce

Steps to reproduce the behavior:

  1. Download any fabric minecraft mod
  2. Download & extract the appropriate yarn mappings for the mod
  3. Select a class file to open & decompile
  4. Apply the yarn mappings
  5. Currently opened class file is not remapped

Exception

N/A

Screenshots

N/A

@Col-E
Copy link
Owner

Col-E commented Sep 27, 2024

Under the "Decompile Pane" config there is an option titled "Accelerate remapping operations" which will use update the AST rather than re-decompile the whole class after changes. In obfuscated scenarios its generally best disabled. Perhaps that could affect this a bit?

Also for reproduction, can you provide a sample that consistently demonstrates the problem?

@Col-E Col-E added Missing details Needs more info to understand the problem 4.X labels Sep 27, 2024
@solonovamax
Copy link
Author

Under the "Decompile Pane" config there is an option titled "Accelerate remapping operations" which will use update the AST rather than re-decompile the whole class after changes. In obfuscated scenarios its generally best disabled. Perhaps that could affect this a bit?

I'm using whatever the default configuration is for recaf, so unsure if I have this enabled.

For sample (although unsure if it reliable reproduces it), just use the exact same class & source jar from my other few issues.

@Col-E
Copy link
Owner

Col-E commented Sep 29, 2024

just use the exact same class & source jar from my other few issues

If it was the same as #862 then I'd close this. If there is another sample that doesn't fall under the problem described in my reply there, please provide a copy here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.X Missing details Needs more info to understand the problem
Projects
None yet
Development

No branches or pull requests

2 participants