Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review PR set_contract_storage() #115

Open
arturoBeccar opened this issue Nov 2, 2023 · 1 comment
Open

Review PR set_contract_storage() #115

arturoBeccar opened this issue Nov 2, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@arturoBeccar
Copy link
Member

Review the PR on set_contract_storage()
use-ink/ink#1961

In particular, review these failing tests:

failures:

---- lazy::mapping::tests::fallible_storage_fails_gracefully_for_overgrown_data stdout ----
thread 'lazy::mapping::tests::fallible_storage_fails_gracefully_for_overgrown_data' panicked at /mnt/dev-disk/OnInk/on-ink_ink_set-contract-storage/crates/env/src/engine/off_chain/impls.rs:202:13:
Value too large to be stored in contract storage, maximum size is 16380 bytes
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- lazy::mapping::tests::fallible_storage_works_for_fitting_data stdout ----
thread 'lazy::mapping::tests::fallible_storage_works_for_fitting_data' panicked at /mnt/dev-disk/OnInk/on-ink_ink_set-contract-storage/crates/env/src/engine/off_chain/impls.rs:202:13:
Value too large to be stored in contract storage, maximum size is 16380 bytes

---- lazy::tests::fallible_storage_works_for_fitting_data stdout ----
thread 'lazy::tests::fallible_storage_works_for_fitting_data' panicked at /mnt/dev-disk/OnInk/on-ink_ink_set-contract-storage/crates/env/src/engine/off_chain/impls.rs:202:13:
Value too large to be stored in contract storage, maximum size is 16380 bytes

---- lazy::tests::fallible_storage_fails_gracefully_for_overgrown_data stdout ----
thread 'lazy::tests::fallible_storage_fails_gracefully_for_overgrown_data' panicked at /mnt/dev-disk/OnInk/on-ink_ink_set-contract-storage/crates/env/src/engine/off_chain/impls.rs:202:13:
Value too large to be stored in contract storage, maximum size is 16380 bytes


failures:
	lazy::mapping::tests::fallible_storage_fails_gracefully_for_overgrown_data
	lazy::mapping::tests::fallible_storage_works_for_fitting_data
	lazy::tests::fallible_storage_fails_gracefully_for_overgrown_data
	lazy::tests::fallible_storage_works_for_fitting_data
@arturoBeccar arturoBeccar added the bug Something isn't working label Nov 2, 2023
@XianPaz XianPaz assigned Helios-vmg and unassigned tenuki Nov 14, 2023
@XianPaz
Copy link
Collaborator

XianPaz commented Nov 16, 2023

reviewed by @Helios-vmg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants