Add options for configuring custom deployments #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi CogStack team!
After doing a few local deployments of the CogStack Nifi project, we made some adjustments to make it easier to configure local parameters, and without running into merge conflicts with the master branch of this repo. It might be nice to also include these changes in master, so that other sites can benefit from this as well.
Changes
deploy/.env-example
in Git and usedeploy/.env
for untracked local configurations.-example
files fornifi.env
enelasticsearch.env
.nifi.env
andelasticsearch.env
todeploy/services.yml
and example files.deploy/services.yml
and example files.Wish list for other PRs
I've left out some other changes we made in our local deployment because it requires changes to parts of the deployment configuration we don't use, e.g. Tika and multiple MedCAT instances (we only use one). And I also wonder what you think about these suggestions, before I make this PR any more complex :)
Use ENV variables for all host ports
This makes it easier to configure ports without changing docker-compose files or
services.yml
. For example:ports: - ${KIBANA_HOST_PORT}:5601
In
deploy/.env
configure:Create example files for all other configs
For example for the elasticsearch
.env
and.yml
files insecurity/
.Update and align MedCATService config
Update and align CogStack-NiFi/services/nlp-services/applications/medcat/config/env_app with https://github.com/CogStack/MedCATservice/blob/master/envs/env_medcat . The MedCATService config contains some old parameters for previous MedCAT versions, while some of the newer parameters are absent from the CogStack NiFi config.
Set NiFI HTTP(S) settings through ENV variables
Currently, the HTTP(S) settings are set in
nifi.properties
. Using environment variables to change these settings has no effect because env vars have a lower priority. So to change the configuration, a change to nifi properties is necessary and a new docker image has to be made. This is not a large task, but it is avoidable by setting the HTTP(S) settings in nifi properties to empty values and setting them with ENV variables, like explained in https://hub.docker.com/r/apache/nifi/Other suggestions