Skip to content
This repository was archived by the owner on Nov 13, 2021. It is now read-only.

Maturity level two issues #104

Merged
merged 16 commits into from
Mar 22, 2019
Merged

Maturity level two issues #104

merged 16 commits into from
Mar 22, 2019

Conversation

pietersap
Copy link
Contributor

@pietersap pietersap commented Mar 18, 2019

This addresses issues

and also the other smaller remarks (see previous merge) by @fgheysels for which there are no seperate issues.

Note: The commits below also includes commits that were already in the previous merge request. I should have kept the commit tree cleaner.

@pietersap pietersap requested a review from fgheysels as a code owner March 18, 2019 13:31
@fgheysels
Copy link
Contributor

I haven't checked yet, but I 'd prefer to have multiple but smaller PR's (for instance one per issue)

@pietersap
Copy link
Contributor Author

Agreed. I will do this from now, but there were no issues created at the time and many modifications are very small like removing whitespace etc :)

@MassimoC MassimoC self-requested a review March 18, 2019 14:23
@pietersap
Copy link
Contributor Author

I'd suggest to first merge this one, before merging any others smaller merge requests that I add in the future.

@MassimoC
Copy link
Collaborator

We already have a first global PR, now I want small PRs with clear title, clear description and link to issue.

@pietersap
Copy link
Contributor Author

@MassimoC Could we still merge this one as a whole? It addresses a lot of smaller remarks by @fgheysels for which there is no issue. Splitting it up now would make it very messy.

@pietersap
Copy link
Contributor Author

I referenced the related issues.

@MassimoC
Copy link
Collaborator

@MassimoC Could we still merge this one as a whole? It addresses a lot of smaller remarks by @fgheysels for which there is no issue. Splitting it up now would make it very messy.

we won't split up :) We will merge as soon reviewed

Copy link
Collaborator

@MassimoC MassimoC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are normally returning problem+json for all the 4XX and 5XX.

@pietersap pietersap requested a review from MassimoC March 20, 2019 10:56
@MassimoC MassimoC self-requested a review March 22, 2019 13:40
@MassimoC MassimoC merged commit 353e3da into master Mar 22, 2019
@MassimoC MassimoC deleted the maturity-level-two-issues branch March 22, 2019 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants