Skip to content
This repository was archived by the owner on Nov 13, 2021. It is now read-only.

Commit 2ff06a5

Browse files
pietersappietersap
authored
fix issue 98 (#107)
1 parent cd2deec commit 2ff06a5

File tree

3 files changed

+18
-48
lines changed

3 files changed

+18
-48
lines changed

‎maturity-level-two/tests/Codit.IntegrationTest/CarTest.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public CarTest()
2727
public async Task GetCars_Ok_TestAsync()
2828
{
2929
//Arrange
30-
var request = new HttpRequestMessage(new HttpMethod("GET"), "/codito/v1/car");
30+
var request = new HttpRequestMessage(HttpMethod.Get, "/codito/v1/car");
3131
//Act
3232
var response = await _httpClient.SendAsync(request);
3333
//Assert
@@ -39,7 +39,7 @@ public async Task GetSingleTeam_Ok_TestAsync()
3939
{
4040
//Arrange
4141
int id = 1;
42-
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/car/{id}");
42+
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/car/{id}");
4343
//Act
4444
var response = await _httpClient.SendAsync(request);
4545
//Arrange
@@ -51,7 +51,7 @@ public async Task GetSingleTeam_NotFound_TestAsync()
5151
{
5252
//Arrange
5353
int id = -1;
54-
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/car/{id}");
54+
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/car/{id}");
5555
//Act
5656
var response = await _httpClient.SendAsync(request);
5757
//Assert

‎maturity-level-two/tests/Codit.IntegrationTest/CustomizationTest.cs

Lines changed: 14 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public CustomizationTest()
2929
public async Task GetCustomizations_Ok_TestAsync()
3030
{
3131
//Arrange
32-
var request = new HttpRequestMessage(new HttpMethod("GET"), "/codito/v1/customization");
32+
var request = new HttpRequestMessage(HttpMethod.Get, "/codito/v1/customization");
3333
//Act
3434
var response = await _httpClient.SendAsync(request);
3535
//Assert
@@ -41,7 +41,7 @@ public async Task GetSingleCustomization_Ok_TestAsync()
4141
{
4242
//Arrange
4343
int id = 1;
44-
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
44+
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
4545
//Act
4646
var response = await _httpClient.SendAsync(request);
4747
//Assert
@@ -54,7 +54,7 @@ public async Task GetSingleCustomiation_NotFound_TestAsync()
5454
{
5555
//Arrange
5656
int id = -1;
57-
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
57+
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
5858
//Act
5959
var response = await _httpClient.SendAsync(request);
6060
//Assert
@@ -102,7 +102,7 @@ public async Task DeleteCustomization_NoContent_TestAsync()
102102
{
103103
//Arrange
104104
int id = -1;
105-
var request = new HttpRequestMessage(new HttpMethod("DELETE"), $"/codito/v1/customization/{id}");
105+
var request = new HttpRequestMessage(HttpMethod.Delete, $"/codito/v1/customization/{id}");
106106
//Act
107107
var response = await _httpClient.SendAsync(request);
108108
//Assert
@@ -115,14 +115,14 @@ public async Task DeleteCustomization_NotFound_TestAsync()
115115
{
116116
//Arrange
117117
int id = 1;
118-
var request = new HttpRequestMessage(new HttpMethod("DELETE"), $"/codito/v1/customization/{id}");
118+
var request = new HttpRequestMessage(HttpMethod.Delete, $"/codito/v1/customization/{id}");
119119
//Act
120120
var response = await _httpClient.SendAsync(request);
121121

122122
//Assert
123123
response.StatusCode.Should().Be(HttpStatusCode.NoContent);
124124

125-
request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
125+
request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
126126
response = await _httpClient.SendAsync(request);
127127
response.StatusCode.Should().Be(HttpStatusCode.NotFound);
128128
}
@@ -133,17 +133,17 @@ public async Task SellCustomization_Accepted_TestAsync()
133133
//Arrange
134134
int id = 1;
135135

136-
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
136+
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
137137
var response = await _httpClient.SendAsync(request);
138138
var actualDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());
139139

140-
request = new HttpRequestMessage(new HttpMethod("POST"), $"/codito/v1/customization/{id}/sale");
140+
request = new HttpRequestMessage(HttpMethod.Post, $"/codito/v1/customization/{id}/sale");
141141
//Act
142142
response = await _httpClient.SendAsync(request);
143143
//Assert
144144
response.StatusCode.Should().Be(HttpStatusCode.Accepted);
145145
// (Inventory must be decremented, number of sales incremented.
146-
request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
146+
request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
147147
response = await _httpClient.SendAsync(request);
148148
var updatedDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());
149149

@@ -157,7 +157,7 @@ public async Task SellCustomization_NotFound_TestAsync()
157157
{
158158
//Arrange
159159
int id = -1;
160-
var request = new HttpRequestMessage(new HttpMethod("POST"), $"/codito/v1/customization/{id}/sale");
160+
var request = new HttpRequestMessage(HttpMethod.Post, $"/codito/v1/customization/{id}/sale");
161161
//Act
162162
var response = await _httpClient.SendAsync(request);
163163
//Assert
@@ -182,28 +182,15 @@ public async Task SellCustomization_SoldOutBadRequest_TestAsync()
182182
var newDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());
183183
int id = newDto.Id;
184184
//(Try to sell this "sold out" customization)
185-
request = new HttpRequestMessage(new HttpMethod("POST"), $"/codito/v1/customization/{id}/sale");
185+
request = new HttpRequestMessage(HttpMethod.Post, $"/codito/v1/customization/{id}/sale");
186186

187187
//Act
188188
response = await _httpClient.SendAsync(request);
189-
189+
190190
//Assert
191191
response.StatusCode.Should().Be(HttpStatusCode.BadRequest);
192-
193192
}
194193

195-
//[Fact]
196-
//public async Task VoteAsBestPlayer_NotFound_TestAsync()
197-
//{
198-
// //Arrange
199-
// int playerId = -1;
200-
// var request = new HttpRequestMessage(new HttpMethod("POST"), $"/world-cup/v1/players/{playerId}/vote");
201-
// //Act
202-
// var response = await _httpClient.SendAsync(request);
203-
// //Assert
204-
// response.StatusCode.Should().Be(HttpStatusCode.NotFound);
205-
//}
206-
207194
[Fact]
208195
public async Task UpdateCustomizationIncremental_NotFound_TestAsync()
209196
{
@@ -214,7 +201,6 @@ public async Task UpdateCustomizationIncremental_NotFound_TestAsync()
214201
InventoryLevel = 100
215202
};
216203

217-
218204
var request = TestExtensions.GetJsonRequest(customization, "PATCH", $"/codito/v1/customization/{id}");
219205

220206
// Act
@@ -234,7 +220,7 @@ public async Task UpdateCustomizationIncremental_NoContent_TestAsync()
234220
InventoryLevel = 100
235221
};
236222

237-
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
223+
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
238224
var response = await _httpClient.SendAsync(request);
239225
var actualDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());
240226
request = TestExtensions.GetJsonRequest(customization, "PATCH", $"/codito/v1/customization/{id}");
@@ -246,7 +232,7 @@ public async Task UpdateCustomizationIncremental_NoContent_TestAsync()
246232

247233
//Assert
248234
response.StatusCode.Should().Be(HttpStatusCode.NoContent);
249-
request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
235+
request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
250236
response = await _httpClient.SendAsync(request);
251237
var updatedDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());
252238
updatedDto.Id.Should().Be(actualDto.Id);
@@ -259,22 +245,6 @@ public async Task UpdateCustomizationIncremental_NoContent_TestAsync()
259245
// this one is updated
260246
updatedDto.InventoryLevel.Should().Be(customization.InventoryLevel);
261247
updatedDto.InventoryLevel.Should().NotBe(actualDto.InventoryLevel);
262-
263-
264248
}
265-
266-
267-
268-
//[Fact]
269-
//public async Task DeletePlayer_NotFound_TestAsync()
270-
//{
271-
// //Arrange
272-
// int playerId = 1;
273-
// var request = new HttpRequestMessage(new HttpMethod("DELETE"), $"/world-cup/v1/players/{playerId}");
274-
// //Act
275-
// var response = await _httpClient.SendAsync(request);
276-
// //Assert
277-
// response.StatusCode.Should().Be(HttpStatusCode.NotFound);
278-
//}
279249
}
280250
}

‎maturity-level-two/tests/Codit.UnitTest/Controllers/carControllerTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public CarControllerTest()
2727
public async Task GetCars_test()
2828
{
2929
//act
30-
var cars = (await _controller.GetCars()) as OkObjectResult;
30+
var cars = (await _controller.GetCars(null)) as OkObjectResult;
3131

3232
//assert
3333
Assert.NotNull(cars);

0 commit comments

Comments
 (0)