Skip to content

Commit ad41caa

Browse files
authored
fix(ci): remove MSIX build steps from release workflow (#16)
The project is currently configured as unpackaged (WindowsPackageType=None), so MSIX packaging doesn't work without additional configuration. Also removed x86 platform - only building x64 and arm64.
1 parent 45a5243 commit ad41caa

File tree

1 file changed

+1
-69
lines changed

1 file changed

+1
-69
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424

2525
strategy:
2626
matrix:
27-
platform: [x64, x86, arm64]
27+
platform: [x64, arm64]
2828

2929
outputs:
3030
version: ${{ steps.version.outputs.VERSION }}
@@ -47,18 +47,9 @@ jobs:
4747
echo "VERSION=$version" >> $env:GITHUB_OUTPUT
4848
echo "Version: $version"
4949
50-
- name: Update version in manifest
51-
shell: pwsh
52-
run: |
53-
$manifest = "src/CodingWithCalvin.VSToolbox/Package.appxmanifest"
54-
$content = Get-Content $manifest -Raw
55-
$content = $content -replace 'Version="[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+"', "Version=`"${{ steps.version.outputs.VERSION }}.0`""
56-
Set-Content $manifest $content
57-
5850
- name: Restore dependencies
5951
run: dotnet restore ${{ env.PROJECT_PATH }}
6052

61-
# Build portable (self-contained) executable
6253
- name: Build portable
6354
run: |
6455
dotnet publish ${{ env.PROJECT_PATH }} `
@@ -76,40 +67,12 @@ jobs:
7667
run: |
7768
Compress-Archive -Path ./artifacts/portable/${{ matrix.platform }}/* -DestinationPath ./artifacts/${{ env.APP_NAME }}-${{ steps.version.outputs.VERSION }}-${{ matrix.platform }}-portable.zip
7869
79-
# Build MSIX package
80-
- name: Build MSIX
81-
run: |
82-
dotnet publish ${{ env.PROJECT_PATH }} `
83-
--configuration Release `
84-
--runtime win-${{ matrix.platform }} `
85-
-p:Platform=${{ matrix.platform }} `
86-
-p:WindowsPackageType=MSIX `
87-
-p:AppxPackageDir=./artifacts/msix/${{ matrix.platform }}/ `
88-
-p:AppxBundle=Never `
89-
-p:UapAppxPackageBuildMode=SideloadOnly `
90-
-p:GenerateAppxPackageOnBuild=true
91-
92-
- name: Find and rename MSIX
93-
shell: pwsh
94-
run: |
95-
$msix = Get-ChildItem -Path ./artifacts/msix/${{ matrix.platform }} -Filter *.msix -Recurse | Select-Object -First 1
96-
if ($msix) {
97-
Copy-Item $msix.FullName "./artifacts/${{ env.APP_NAME }}-${{ steps.version.outputs.VERSION }}-${{ matrix.platform }}.msix"
98-
}
99-
10070
- name: Upload portable artifact
10171
uses: actions/upload-artifact@v4
10272
with:
10373
name: portable-${{ matrix.platform }}
10474
path: ./artifacts/${{ env.APP_NAME }}-${{ steps.version.outputs.VERSION }}-${{ matrix.platform }}-portable.zip
10575

106-
- name: Upload MSIX artifact
107-
uses: actions/upload-artifact@v4
108-
with:
109-
name: msix-${{ matrix.platform }}
110-
path: ./artifacts/${{ env.APP_NAME }}-${{ steps.version.outputs.VERSION }}-${{ matrix.platform }}.msix
111-
if-no-files-found: warn
112-
11376
release:
11477
needs: [changelog, build]
11578
runs-on: ubuntu-latest
@@ -135,37 +98,6 @@ jobs:
13598
tag: ${{ github.ref_name }}
13699
prerelease: ${{ contains(github.ref_name, '-') }}
137100

138-
# TODO: Enable Microsoft Store submission once secrets are configured
139-
# store:
140-
# needs: [build, release]
141-
# runs-on: windows-latest
142-
# if: ${{ !contains(github.ref_name, '-') }} # Skip for pre-releases
143-
#
144-
# steps:
145-
# - name: Checkout
146-
# uses: actions/checkout@v4
147-
#
148-
# - name: Download MSIX artifacts
149-
# uses: actions/download-artifact@v4
150-
# with:
151-
# pattern: msix-*
152-
# path: msix-packages
153-
# merge-multiple: true
154-
#
155-
# - name: List MSIX packages
156-
# shell: pwsh
157-
# run: Get-ChildItem -Path msix-packages -Recurse
158-
#
159-
# - name: Submit to Microsoft Store
160-
# uses: microsoft/store-submission@v1
161-
# with:
162-
# command: publish
163-
# productId: ${{ secrets.STORE_PRODUCT_ID }}
164-
# tenantId: ${{ secrets.AZURE_TENANT_ID }}
165-
# clientId: ${{ secrets.AZURE_CLIENT_ID }}
166-
# clientSecret: ${{ secrets.AZURE_CLIENT_SECRET }}
167-
# packagePath: msix-packages/
168-
169101
notify-bluesky:
170102
needs: [release]
171103
if: ${{ !contains(github.ref_name, '-') }}

0 commit comments

Comments
 (0)