Improvement/add request timeout handler #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingAleCR
reviewed
Jan 25, 2022
CodingAleCR
requested changes
Jan 25, 2022
|
Also, great job! It's really good that you are taking point on this, I really appreciate it and I know library users will too! |
CodingAleCR
approved these changes
Mar 11, 2022
…into improvement/add-request-timeout-handler
|
@all-contributors add javiermrz for code |
|
I've put up a pull request to add @javiermrz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function() onRequestTimeoutto the classInterceptedClientand as parameter of the factoryInterceptedClient.build.onRequestTimeoutis defined and the request times out,onRequestTimeoutwill get executed, and afterwards aTimeoutExceptionwill be thrown (theonTimeouthandler of aFutureonly allows callbacks that either throw an error or return a variable ofFutureOr<StreamedResponse>in this case). Returning a random/blank response in case of timeout didn't really make sense, throwing an error seemed more correct.