Fix stdout/stderr handling to prevent JSON-RPC communication errors #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stdout/stderr handling to prevent JSON-RPC communication errors
This PR addresses an issue where debug messages were being output to stdout, which interfered with the JSON-RPC protocol. The MCP protocol requires that stdout be used exclusively for JSON-RPC messages.
Changes
logDebug()function to useconsole.error()instead ofconsole.debug()console.warn()withconsole.error()console.log()withconsole.error()for server status messagesThese changes ensure that stdout is used exclusively for JSON-RPC communication, while all logging and debugging information goes to stderr, making godot-mcp more compatible with MCP clients that strictly follow the protocol specification.
Testing
Tested with Claude's MCP client, which previously failed with JSON parsing errors. After these changes, the communication works correctly.
Issues
#24