Fix - Dropping mencoder bin on disposing even when async encoding is running

Author: stesee

MencoderSharp/Mencoder.cs

@@ -28,8 +28,8 @@ public bool EncodeToMp4(string source, string destination)
         /// </summary>
         /// <param name="source">The source.</param>
         /// <param name="destination">The destination.</param>
-        /// <param name="videoParameter">The video parameter.</param>
-        /// <param name="audioParameter">The audio parameter.</param>
+        /// <param name="videoParameter">The video parameter e.g. "-vf dsize=16/9,scale=-10:-1,harddup -of lavf -lavfopts format=mp4 -ovc x264 -sws 9 -x264encopts nocabac:level_idc=30:bframes=0:bitrate=512:threads=auto:global_header:threads=auto"</param>
+        /// <param name="audioParameter">The audio parameter e.g. "-oac mp3lame"</param>
         /// <returns>True if task finishes without error</returns>
         public bool Mencode(string source, string destination, string videoParameter, string audioParameter)
         {

MencoderSharp/MencoderBase.cs

@@ -1,7 +1,9 @@
 using System;
+using System.Diagnostics;
 using System.IO;
 using System.Reflection;
 using System.Runtime.InteropServices;
+using System.Threading.Tasks;
 
 namespace MencoderSharp
 {
@@ -116,6 +118,14 @@ protected virtual void Dispose(bool disposing)
 
                 if (!customMencoderLocation && File.Exists(PathToExternalMencoderBin))
                 {
+                    foreach (var process in Process.GetProcessesByName(Path.GetFileNameWithoutExtension(PathToExternalMencoderBin)))
+                    {
+                        if (!process.HasExited)
+                        {
+                            process.Kill();
+                            Task.Delay(5).Wait();
+                        }
+                    }
                     File.Delete(PathToExternalMencoderBin);
                 }
 

MencoderSharpTest/MencoderSharpIntegrationTest.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Diagnostics;
 using System.IO;
 using System.Threading.Tasks;
 using Xunit;
@@ -43,6 +44,22 @@ public void ShouldStartEncodeAsync()
             AssertVeraPdfGotDisposed();
         }
 
+        [Fact]
+        public void ShouldDisposeWithoutExceptionWhileEncodeAsync()
+        {
+            using (var mencoderAsync = new MencoderSharp.MencoderAsync())
+            {
+                mencoderAsync.Finished += Mencoder_Finished;
+                mencoderAsync.ProgressChanged += Mencoder_Progress;
+                mencoderAsync.StartEncodeAsync("./TestFiles/HelloWorld.avi", "./TestOutput.mp4");
+                while (Process.GetProcessesByName(Path.GetFileNameWithoutExtension(mencoderAsync.PathToExternalMencoderBin)).Length == 0)
+                {
+                    Task.Delay(50).Wait();
+                }
+            }
+            AssertVeraPdfGotDisposed();
+        }
+
         [Fact]
         public void ShouldStartEncodeAsyncAndCancle()
         {
@@ -75,20 +92,21 @@ public void ShouldStartEncodeAsyncAndCancle()
         [Fact]
         public void ShouldStartEncodeSync()
         {
-            asyncTaskRunning = false;
-            using (var mencoderAsync = new MencoderSharp.MencoderAsync())
+            using (var mencoderSync = new MencoderSharp.Mencoder())
             {
-                mencoderAsync.Finished += Mencoder_Finished;
-                mencoderAsync.ProgressChanged += Mencoder_Progress;
-                mencoderAsync.StartEncodeAsync("./TestFiles/small.mp4", "./SmallTestOutput.mp4");
-                pathToExternalMencoderBin = mencoderAsync.PathToExternalMencoderBin;
-                asyncTaskRunning = true;
-                while (asyncTaskRunning)
-                {
-                    Task.Delay(1000);
-                }
-                Assert.InRange(progress, 1, 100);
-                Assert.True(mencoderAsync.Result.ExecutionWasSuccessfull, mencoderAsync.Result.StandardError);
+                Assert.True(mencoderSync.Mencode("./TestFiles/small.mp4", "./SmallTestOutput.mp4", "-vf dsize=16/9,scale=-10:-1,harddup -of lavf -lavfopts format=mp4 -ovc x264 -sws 9 -x264encopts nocabac:level_idc=30:bframes=0:bitrate=512:threads=auto:global_header:threads=auto", "-oac mp3lame"));
+                pathToExternalMencoderBin = mencoderSync.PathToExternalMencoderBin;
+            }
+            AssertVeraPdfGotDisposed();
+        }
+
+        [Fact]
+        public void ShouldDetectEncodeSyncFail()
+        {
+            using (var mencoderSync = new MencoderSharp.Mencoder())
+            {
+                Assert.False(mencoderSync.Mencode("./TestFiles/DoesNotExist", "./SmallTestOutput.mp4", "-vf dsize=16/9,scale=-10:-1,harddup -of lavf -lavfopts format=mp4 -ovc x264 -sws 9 -x264encopts nocabac:level_idc=30:bframes=0:bitrate=512:threads=auto:global_header:threads=auto", "-oac mp3lame"));
+                pathToExternalMencoderBin = mencoderSync.PathToExternalMencoderBin;
             }
             AssertVeraPdfGotDisposed();
         }