refactor: Avoid barrel imports within project

Author: Danielku15

.vscode/settings.json

@@ -6,6 +6,7 @@
             "**/node_modules/.vite-temp/**"
         ]
     },
+    "typescript.preferences.importModuleSpecifier": "non-relative",
     "[typescript]": {
         "editor.defaultFormatter": "biomejs.biome"
     },

src.compiler/typescript/CloneEmitter.ts

@@ -80,7 +80,7 @@ function generateClonePropertyStatements(
                 .filter(t => t.tagName.text === 'clone_add')
                 .map(t => t.comment ?? '')[0] as string;
 
-            importer(`${arrayItemType.typeAsString}Cloner`, `./${arrayItemType.typeAsString}Cloner`);
+            importer(`${arrayItemType.typeAsString}Cloner`, `@src/generated/model/${arrayItemType.typeAsString}Cloner`);
             const loopItems = [
                 ...assign(ts.factory.createArrayLiteralExpression(undefined)),
 
@@ -206,7 +206,7 @@ function generateClonePropertyStatements(
         }
     } else {
         if (propertyType.isCloneable) {
-            importer(`${propertyType.typeAsString}Cloner`, `./${propertyType.typeAsString}Cloner`);
+            importer(`${propertyType.typeAsString}Cloner`, `@src/generated/model/${propertyType.typeAsString}Cloner`);
 
             // clone.prop = original.prop ? TypeNameCloner.clone(original.prop) : null
             // clone.prop = original.prop ? TypeNameCloner.clone(original.prop) : undefined

src.compiler/typescript/JsonDeclarationEmitter.ts

@@ -69,7 +69,7 @@ function createJsonTypeNode(
         if (isOwnType) {
             const isGeneratedJsonDeclaration = typeInfo.jsDocTags?.some(t => t.tagName.text === 'json_declaration');
             if (isGeneratedJsonDeclaration) {
-                importer(`${typeInfo.typeAsString}Json`, `./${typeInfo.typeAsString}Json`);
+                importer(`${typeInfo.typeAsString}Json`, `@src/generated/${typeInfo.typeAsString}Json`);
             } else {
                 importer(`${typeInfo.typeAsString}Json`, typeInfo.modulePath);
             }
@@ -205,7 +205,7 @@ const emit = createEmitter('json_declaration', (program, input) => {
         )
     );
 
-    allJsonTypes.set(`${input.name!.text}Json`, `./${input.name!.text}Json`);
+    allJsonTypes.set(`${input.name!.text}Json`, `@src/generated/${input.name!.text}Json`);
     const sourceFile = ts.factory.createSourceFile(
         [...statements],
         ts.factory.createToken(ts.SyntaxKind.EndOfFileToken),
@@ -236,5 +236,5 @@ export default function emitWithIndex(program: ts.Program, _diagnostics: ts.Diag
         ts.NodeFlags.None
     );
 
-    generateFile(program, sourceFile, 'json.ts');
+    generateFile(program, sourceFile, '_jsonbarrel.ts');
 }

src/AlphaTabApiBase.ts

@@ -91,11 +91,11 @@ import type { MidiEventType } from '@src/midi/MidiEvent';
 import type { MidiEventsPlayedEventArgs } from '@src/synth/MidiEventsPlayedEventArgs';
 import type { PlaybackRangeChangedEventArgs } from '@src/synth/PlaybackRangeChangedEventArgs';
 import { ActiveBeatsChangedEventArgs } from '@src/synth/ActiveBeatsChangedEventArgs';
-import type { BeatTickLookupItem } from './midi/BeatTickLookup';
-import type { ISynthOutputDevice } from './synth/ISynthOutput';
+import type { BeatTickLookupItem } from '@src/midi/BeatTickLookup';
+import type { ISynthOutputDevice } from '@src/synth/ISynthOutput';
 
 // biome-ignore lint/correctness/noUnusedImports: https://github.com/biomejs/biome/issues/4677
-import type { CoreSettings } from './CoreSettings';
+import type { CoreSettings } from '@src/CoreSettings';
 
 class SelectionInfo {
     public beat: Beat;

src/CoreSettings.ts

@@ -1,7 +1,7 @@
 import { Environment } from '@src/Environment';
 import { LogLevel } from '@src/LogLevel';
 // biome-ignore lint/correctness/noUnusedImports: https://github.com/biomejs/biome/issues/4677
-import type { BoundsLookup } from './rendering';
+import type { BoundsLookup } from '@src/rendering/utils/BoundsLookup';
 
 /**
  * All main settings of alphaTab controlling rather general aspects of its behavior.

src/DisplaySettings.ts

@@ -2,7 +2,7 @@ import { RenderingResources } from '@src/RenderingResources';
 import { LayoutMode } from '@src/LayoutMode';
 import { StaveProfile } from '@src/StaveProfile';
 // biome-ignore lint/correctness/noUnusedImports: https://github.com/biomejs/biome/issues/4677
-import type { Staff } from './model';
+import type { Staff } from '@src/model/Staff';
 
 /**
  * Lists the different modes in which the staves and systems are arranged.

src/Environment.ts

@@ -55,25 +55,25 @@ import { ResizeObserverPolyfill } from '@src/platform/javascript/ResizeObserverP
 import { WebPlatform } from '@src/platform/javascript/WebPlatform';
 import { IntersectionObserverPolyfill } from '@src/platform/javascript/IntersectionObserverPolyfill';
 import { AlphaSynthWebWorklet } from '@src/platform/javascript/AlphaSynthAudioWorkletOutput';
-import { SkiaCanvas } from './platform/skia/SkiaCanvas';
-import type { Font } from './model';
-import type { Settings } from './Settings';
-import { AlphaTabError, AlphaTabErrorType } from './AlphaTabError';
-import { SlashBarRendererFactory } from './rendering/SlashBarRendererFactory';
-import { NumberedBarRendererFactory } from './rendering/NumberedBarRendererFactory';
-import { FreeTimeEffectInfo } from './rendering/effects/FreeTimeEffectInfo';
-import { ScoreBarRenderer } from './rendering/ScoreBarRenderer';
-import { TabBarRenderer } from './rendering/TabBarRenderer';
-import { SustainPedalEffectInfo } from './rendering/effects/SustainPedalEffectInfo';
-import { GolpeEffectInfo } from './rendering/effects/GolpeEffectInfo';
-import { GolpeType } from './model/GolpeType';
-import { WahPedalEffectInfo } from './rendering/effects/WahPedalEffectInfo';
-import { BeatBarreEffectInfo } from './rendering/effects/BeatBarreEffectInfo';
-import { NoteOrnamentEffectInfo } from './rendering/effects/NoteOrnamentEffectInfo';
-import { RasgueadoEffectInfo } from './rendering/effects/RasgueadoEffectInfo';
-import { DirectionsEffectInfo } from './rendering/effects/DirectionsEffectInfo';
-import { BeatTimerEffectInfo } from './rendering/effects/BeatTimerEffectInfo';
-import { VersionInfo } from './generated/VersionInfo';
+import { SkiaCanvas } from '@src/platform/skia/SkiaCanvas';
+import type { Font } from '@src/model/Font';
+import type { Settings } from '@src/Settings';
+import { AlphaTabError, AlphaTabErrorType } from '@src/AlphaTabError';
+import { SlashBarRendererFactory } from '@src/rendering/SlashBarRendererFactory';
+import { NumberedBarRendererFactory } from '@src/rendering/NumberedBarRendererFactory';
+import { FreeTimeEffectInfo } from '@src/rendering/effects/FreeTimeEffectInfo';
+import { ScoreBarRenderer } from '@src/rendering/ScoreBarRenderer';
+import { TabBarRenderer } from '@src/rendering/TabBarRenderer';
+import { SustainPedalEffectInfo } from '@src/rendering/effects/SustainPedalEffectInfo';
+import { GolpeEffectInfo } from '@src/rendering/effects/GolpeEffectInfo';
+import { GolpeType } from '@src/model/GolpeType';
+import { WahPedalEffectInfo } from '@src/rendering/effects/WahPedalEffectInfo';
+import { BeatBarreEffectInfo } from '@src/rendering/effects/BeatBarreEffectInfo';
+import { NoteOrnamentEffectInfo } from '@src/rendering/effects/NoteOrnamentEffectInfo';
+import { RasgueadoEffectInfo } from '@src/rendering/effects/RasgueadoEffectInfo';
+import { DirectionsEffectInfo } from '@src/rendering/effects/DirectionsEffectInfo';
+import { BeatTimerEffectInfo } from '@src/rendering/effects/BeatTimerEffectInfo';
+import { VersionInfo } from '@src/generated/VersionInfo';
 
 /**
  * A factory for custom layout engines.

src/FileLoadError.ts

@@ -1,4 +1,4 @@
-import { AlphaTabError, AlphaTabErrorType } from './AlphaTabError';
+import { AlphaTabError, AlphaTabErrorType } from '@src/AlphaTabError';
 
 /**
  * @target web

src/RenderingResources.ts

@@ -1,6 +1,6 @@
 import { Color } from '@src/model/Color';
 import { Font, FontStyle, FontWeight } from '@src/model/Font';
-import { ScoreSubElement } from './model';
+import { ScoreSubElement } from '@src/model/Score';
 
 /**
  * This public class contains central definitions for controlling the visual appearance.

src/Settings.ts

@@ -4,7 +4,7 @@ import { ImporterSettings } from '@src/ImporterSettings';
 import { FingeringMode, NotationMode, NotationSettings, NotationElement } from '@src/NotationSettings';
 import { PlayerSettings } from '@src/PlayerSettings';
 import { SettingsSerializer } from '@src/generated/SettingsSerializer';
-import type { SettingsJson } from './generated/SettingsJson';
+import type { SettingsJson } from '@src/generated/SettingsJson';
 
 /**
  * This public class contains instance specific settings for alphaTab