Skip to content

Fix scaling bug on FlxView3D on High DPI displays #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kitzsh
Copy link
Contributor

@kitzsh kitzsh commented Jun 30, 2025

Fixes a bug in FlxView3D where the underlying View3D is larger than the BitmapData it renders to when "allow-high-dpi" is enabled, only showing the top left-hand corner of the view.

@kitzsh kitzsh marked this pull request as draft June 30, 2025 03:22
@kitzsh
Copy link
Contributor Author

kitzsh commented Jun 30, 2025

Needs more testing actually

@kitzsh
Copy link
Contributor Author

kitzsh commented Jun 30, 2025

Tested it with a few different resolutions, should be all clear

@kitzsh kitzsh marked this pull request as ready for review June 30, 2025 03:33
@crowplexus crowplexus added the type:bug Something isn't working label Jun 30, 2025
@crowplexus
Copy link
Member

OH SO THAT'S WHY????

@kitzsh
Copy link
Contributor Author

kitzsh commented Jun 30, 2025

yup

Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhhh
so thats why

@NexIsDumb
Copy link
Member

was this actually tested enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants