Skip to content

Commit 88ec8eb

Browse files
author
Anh-Duy Le
committed
DLE-190517-Update small change for api param model
1 parent d354fe6 commit 88ec8eb

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

domains/config/ConfigApiParamModel.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,10 @@ def default_value(self):
2525
def default_value(self, val):
2626
self.__default_value = val
2727

28+
@property
29+
def current_value(self):
30+
return self.__current_value
31+
@current_value.setter
32+
def current_value(self, val):
33+
self.__current_value = val
34+

service/banking/exchangerate_service.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,13 @@ def __init_apiUrl(self):
4040
return None
4141

4242

43-
def __init_apiParamsString(self):
43+
def __init_apiParamsString(self, lstParamModel):
4444
if self.ApiConfig1:
4545
lstApiParam = self.domain_factory.map_ListJsonToListDomainClass(self.ConfigApiParamModel, self.ApiConfig1.api_params)
4646
apiStr = ""
4747
for idx, para in enumerate(lstApiParam):
48+
if lstParamModel and len(lstParamModel) > 0:
49+
pr = [pr for pr in lstParamModel if pr.param_name == para.param_name]
4850
singleParam = "{0}={1}".format(para.param_name, para.default_value)
4951
if(idx == 0):
5052
apiStr = singleParam
@@ -54,8 +56,12 @@ def __init_apiParamsString(self):
5456
return None
5557

5658

57-
def get_exrate_byDate(self, dateReport, baseCurrency):
58-
apiUrl = "{0}{1}{2}?{3}".format(self.__init_apiUrl(), dateReport, self.ApiConfig1.api_extension, self.__init_apiParamsString())
59+
def get_exrate_byDate(self, dateReport, baseCurrency):
60+
modelBaseCurParam = self.ConfigApiParamModel()
61+
modelBaseCurParam.param_name = "base"
62+
modelBaseCurParam.current_value = baseCurrency
63+
64+
apiUrl = "{0}{1}{2}?{3}".format(self.__init_apiUrl(), dateReport, self.ApiConfig1.api_extension, self.__init_apiParamsString(list(modelBaseCurParam))
5965
if apiUrl:
6066
content = self.util_data.readJsonFromUrl(apiUrl)
6167
return content

unit_tests/test_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def test_exrate__get_specific_exrate_byDateRange(self):
4848

4949
fromDate = '2016-01-1'
5050
toDate = '2016-12-30'
51-
checkedDate = [15, 5, 10, 20]
51+
checkedDate = [15, 1, 5, 10, 20, 25]
5252
baseCurrency = 'USD'
5353
toCurrency = 'VND'
5454

0 commit comments

Comments
 (0)