Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event-stream vulnerability issue #1

Open
JavierCane opened this issue Nov 27, 2018 · 1 comment
Open

Fix event-stream vulnerability issue #1

JavierCane opened this issue Nov 27, 2018 · 1 comment
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@JavierCane
Copy link
Member

We have the following two security alerts opened by GitHub:

image
image

These security bugs are related to the just published vulnerabilities on the event-stream package in versions 3.3.6 and later. Here we can find more information about it:

Seeking for the usage of the event-stream package in the examples, I've found the following occurrences:

It seems to be added as a transitive dependency by the ps-tree@^1.1.0 package, which is added by the pstree.remy@^1.1.0 one, added by the nodemon@^1.11.0 one. This nodemon package is the one we really ask for in our package.json.

Searching for related issues, we can see the following ones in the nodemon repo:

The commit referenced as a fix for the vulnerability doesn't contain the removal of the pstree[.remy] dependency, however, they explicitly claim it solves it.

@juanmaguitar:

  • Can you please help us out in how to solve this issue?
  • It would be enough just bumping from "nodemon": "^1.11.0" to "nodemon": "^1.18.7" in our package.json?
  • Would it be compatible with the rest of the app?
  • Additionally, I would recommend checking out the servers where you've deployed the app in order to fix this vulnerability 👼
@JavierCane JavierCane added bug Something isn't working help wanted Extra attention is needed labels Nov 27, 2018
@JavierCane JavierCane self-assigned this Nov 27, 2018
@juanmaguitar
Copy link
Collaborator

juanmaguitar commented Nov 30, 2018

@JavierCane nodemon package is a package only needed for development so:

  • Is not a critical issue because the vulnerability only affects to development environment (not production)
  • Updating the nodemon package (as you say) should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants