Skip to content

Select only necessary fields for submitForm() #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2021
Merged

Select only necessary fields for submitForm() #84

merged 1 commit into from
Dec 25, 2021

Conversation

dahaupt
Copy link
Contributor

@dahaupt dahaupt commented Dec 9, 2021

This changes the selector of fields used in submitForm() to get only
fields with a name attribute.

Fixes: #83

@dahaupt
Select only necessary fields for submitForm()
63a939b 
This changes the selector of fields used in `submitForm()` to get only
fields with a `name` attribute.

Fixes: Codeception#83
@dahaupt
Copy link
Contributor Author

dahaupt commented Dec 9, 2021

Instead of checking for the name attribute, I modified the selector to get only matching elements. But there may be a better (shorter) selector.

@Naktibalda
Copy link
Member

Thanks

@Naktibalda Naktibalda merged commit 930ebf7 into Codeception:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

submitForm throws TypeError for input fields without name attribute
2 participants
@dahaupt @Naktibalda