Skip to content

Negative tab offset crashes #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2022
Merged

Negative tab offset crashes #108

merged 4 commits into from
Sep 11, 2022

Conversation

webmaster777
Copy link
Contributor

Two things:

  • Fix a bug when the current tab (window handle) is the first in the list, the previous handle is accessed via key -1, which doesn't exist.
  • Prevent closing the last tab, it will destroy the selenium session (most likely unintentionally).

@webmaster777 webmaster777 force-pushed the negative-tab-offset-crashes branch from cffa03b to 6374d5f Compare September 8, 2022 08:46
webmaster777
webmaster777 commented Sep 8, 2022
View reviewed changes
@Naktibalda Naktibalda merged commit c20b757 into Codeception:master Sep 11, 2022
@Naktibalda
Copy link
Member

Released as 3.1.3, 2.0.4 and 1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster777 @Naktibalda