Mitigate validate agents error

Author: jahooma

cli/src/components/validation-error-popover.tsx

@@ -77,9 +77,10 @@ export const ValidationErrorPopover: React.FC<ValidationErrorPopoverProps> = ({
         </box>
 
         <box style={{ flexDirection: 'column', paddingTop: 1, gap: 0 }}>
-          {errors.slice(0, 3).map((error) => {
-            const agentId = error.id.replace(/_\d+$/, '')
-            const isNetworkError = error.id === NETWORK_ERROR_ID
+          {errors.slice(0, 3).map((error, index) => {
+            const errorId = error.id ?? ''
+            const agentId = errorId.replace(/_\d+$/, '')
+            const isNetworkError = errorId === NETWORK_ERROR_ID
             const agentInfo = loadedAgentsData?.agents.find(
               (a) => a.id === agentId,
             ) as LocalAgentInfo | undefined
@@ -91,7 +92,7 @@ export const ValidationErrorPopover: React.FC<ValidationErrorPopoverProps> = ({
             if (isNetworkError) {
               return (
                 <box
-                  key={error.id}
+                  key={errorId || `error-${index}`}
                   style={{ flexDirection: 'column', paddingTop: 0.5 }}
                 >
                   <text style={{ fg: theme.muted, wrapMode: 'word' }}>
@@ -104,7 +105,7 @@ export const ValidationErrorPopover: React.FC<ValidationErrorPopoverProps> = ({
             if (agentInfo?.filePath) {
               return (
                 <box
-                  key={error.id}
+                  key={errorId || `error-${index}`}
                   style={{ flexDirection: 'column', paddingTop: 0.5 }}
                 >
                   <text style={{ fg: theme.muted, wrapMode: 'word' }}>
@@ -131,11 +132,11 @@ export const ValidationErrorPopover: React.FC<ValidationErrorPopoverProps> = ({
 
             return (
               <box
-                key={error.id}
+                key={errorId || `error-${index}`}
                 style={{ flexDirection: 'column', paddingTop: 0.5 }}
               >
                 <text style={{ fg: theme.muted, wrapMode: 'word' }}>
-                  {`• ${agentId}`}
+                  {`• ${agentId || 'Unknown'}`}
                 </text>
                 <text
                   style={{

cli/src/hooks/use-send-message.ts

@@ -103,7 +103,7 @@ export const useSendMessage = ({
   onBeforeMessageSend,
   mainAgentTimer,
   scrollToLatest,
-  onTimerEvent = () => {},
+  onTimerEvent = () => { },
   isQueuePausedRef,
   isProcessingQueueRef,
   resumeQueue,
@@ -289,12 +289,13 @@ export const useSendMessage = ({
           const errorsToAttach =
             validationResult.errors.length === 0
               ? [
-                  {
-                    id: NETWORK_ERROR_ID,
-                    message:
-                      'Agent validation failed. This may be due to a network issue or temporary server problem. Please try again.',
-                  },
-                ]
+                // Hide this for now, as validate endpoint may be flaky and we don't want to bother users.
+                // {
+                //   id: NETWORK_ERROR_ID,
+                //   message:
+                //     'Agent validation failed. This may be due to a network issue or temporary server problem. Please try again.',
+                // },
+              ]
               : validationResult.errors
 
           setMessages((prev) =>

sdk/src/validate-agents.ts

@@ -143,7 +143,7 @@ export async function validateAgents(
 
   // Transform validation errors to the SDK format
   const transformedErrors = validationErrors.map((error) => ({
-    id: error.filePath,
+    id: error.filePath ?? 'unknown',
     message: error.message,
   }))