Skip to content

Commit

Permalink
Fix migrate release from github (go-gitea#19510) (go-gitea#19523)
Browse files Browse the repository at this point in the history
* Fix migrate release from github

* Fix bug
  • Loading branch information
lunny authored and fnetX committed Apr 28, 2022
1 parent 67c4cf3 commit 9b00d79
Showing 1 changed file with 12 additions and 9 deletions.
21 changes: 12 additions & 9 deletions services/migrations/gitea_uploader.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package migrations

import (
"context"
"errors"
"fmt"
"io"
"net/url"
Expand Down Expand Up @@ -247,7 +248,6 @@ func (g *GiteaLocalUploader) CreateReleases(releases ...*base.Release) error {
LowerTagName: strings.ToLower(release.TagName),
Target: release.TargetCommitish,
Title: release.Name,
Sha1: release.TargetCommitish,
Note: release.Body,
IsDraft: release.Draft,
IsPrerelease: release.Prerelease,
Expand Down Expand Up @@ -276,15 +276,18 @@ func (g *GiteaLocalUploader) CreateReleases(releases ...*base.Release) error {
rel.OriginalAuthorID = release.PublisherID
}

// calc NumCommits if no draft
if !release.Draft {
// calc NumCommits if possible
if rel.TagName != "" {
commit, err := g.gitRepo.GetTagCommit(rel.TagName)
if err != nil {
return fmt.Errorf("GetTagCommit[%v]: %v", rel.TagName, err)
}
rel.NumCommits, err = commit.CommitsCount()
if err != nil {
return fmt.Errorf("CommitsCount: %v", err)
if !errors.Is(err, git.ErrNotExist{}) {
if err != nil {
return fmt.Errorf("GetTagCommit[%v]: %v", rel.TagName, err)
}
rel.Sha1 = commit.ID.String()
rel.NumCommits, err = commit.CommitsCount()
if err != nil {
return fmt.Errorf("CommitsCount: %v", err)
}
}
}

Expand Down

0 comments on commit 9b00d79

Please sign in to comment.