Content : HTML CSS Week 1 #188
Conversation
generic and reusable
- created some reusable blocks for study time - Mitch you might want to update this language and use them yourself - I made a bunch of features and changes as I was writing this and so the views will look broken until those prs are merged
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
generic and reusable
- created some reusable blocks for study time - Mitch you might want to update this language and use them yourself - I made a bunch of features and changes as I was writing this and so the views will look broken until those prs are merged
illicitonion
force-pushed
the
content/html-css-w1
branch
from
50e0377 to
d8a0a86
Compare
This is covered in the videos but sure Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
There was a problem hiding this comment.
This looks great! I filed CodeYourFuture/CYF-Workshops#95 with a few minor copy edits for the workshop, and left a few comments and discussions here, otherwise LGTM!
|
|
||
| {{<tab name="Video">}} | ||
| {{<youtube>}} | ||
| https://youtu.be/U1QWx8xbbt4 |
There was a problem hiding this comment.
This video doesn't seem to be loading in the tab?
| src="https://www.youtube.com/watch?v=mBmX7944vd0&list=PLozA7cloMbPgk5gK8His2CeuJTKofypbV&index=7" | ||
| [[blocks]] | ||
| name="Bikes for Refugees" | ||
| src="https://github.com/CodeYourFuture/bikes-for-refugees/readme" |
There was a problem hiding this comment.
In the rendered text for this block, we have the text "Clone this repository onto your machine", but there's no context as to what repository it is. In the README itself, it can be assumed you have that context, but if we're just in-lining the content into another page, that context is lost, and we'll need to add it somehow...
Also, I just filed #202 about migrating the git cheat-sheet and #203 about updating the branch creation instructions
There was a problem hiding this comment.
It would be nice to have a github clone button type thing.
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
What does this change?
Module: HTML CSS
Week(s): 1
Checklist
Description
IMPORTANT: I made multiple features and fixes while writing this content. I opened them all as feature scoped branches and those PRs must be merged before this content will render correctly.
Who needs to know about this?
Rendered Pages