Skip to content

London| Forogh Aghaeiyarijani | Module-Structuring-and-testing-data |sprint 2 | WEEK 2 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

London| Forogh Aghaeiyarijani | Module-Structuring-and-testing-data |sprint 2 | WEEK 2 #117

wants to merge 4 commits into from

Conversation

Forogh-Aghaeiyarijani
Copy link

@Forogh-Aghaeiyarijani Forogh-Aghaeiyarijani commented Nov 11, 2024 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Forogh-Aghaeiyarijani Forogh-Aghaeiyarijani added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 11, 2024
SallyMcGrath
SallyMcGrath suggested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Forogh-Aghaeiyarijani

Thanks for this, but your PR contains all the changes from Sprint 1 as well. Please open a PR with just the changes for sprint 2. Lots of people have trouble with this at first, so ask in Slack or come to class to fix up your PR.

@SallyMcGrath SallyMcGrath added 👀 Review Git Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 18, 2024
@Forogh-Aghaeiyarijani Forogh-Aghaeiyarijani changed the title London| Forogh Aghaeiyarijani | Bug/sprint 2 | WEEK 2 London| Forogh Aghaeiyarijani | Module-Structuring-and-testing-data |Bug/sprint 2 | WEEK 2 Nov 19, 2024
@Forogh-Aghaeiyarijani Forogh-Aghaeiyarijani changed the title London| Forogh Aghaeiyarijani | Module-Structuring-and-testing-data |Bug/sprint 2 | WEEK 2 London| Forogh Aghaeiyarijani | Module-Structuring-and-testing-data |sprint 2 | WEEK 2 Nov 19, 2024
@Forogh-Aghaeiyarijani
Copy link
Author

Hi @SallyMcGrath , Thank you for reviewing. I found the solution from Slack. It has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@SallyMcGrath SallyMcGrath SallyMcGrath requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review with trainee action still to take.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Forogh-Aghaeiyarijani @SallyMcGrath