proper fractions jest tests

Author: RaihanSharif

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,6 +11,7 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
+  if (denominator === 0) return false;
   return numerator < denominator ? true : false;
 }
 

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -7,4 +7,33 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 // Special case: numerator is zero
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
+  expect(isProperFraction(0, 0)).toEqual(false);
+  expect(isProperFraction(-1, 0)).toEqual(false);
+});
+
+test(`should return true when numerator and denominator both positive and numerator < denominator`, () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
+  expect(isProperFraction(4, 5)).toEqual(true);
+  expect(isProperFraction(2, 3)).toEqual(true);
+});
+
+test(`should return true when numerator and denominator both negative and numerator < denominator`, () => {
+  expect(isProperFraction(-3, -2)).toEqual(true);
+});
+
+test(`should return true when numerator is negative and numerator < denominator`, () => {
+  expect(isProperFraction(-3, 2)).toEqual(true);
+});
+
+test(`should return false when numerator > denominator`, () => {
+  expect(isProperFraction(2, 1)).toEqual(false);
+});
+
+test(`should return false when numerator > denominator, negative nums`, () => {
+  expect(isProperFraction(-1, -2)).toEqual(false);
+});
+
+test(`should return false when numerator == denominator`, () => {
+  expect(isProperFraction(-2, -2)).toEqual(false);
+  expect(isProperFraction(2, 2)).toEqual(false);
 });