Final attempt on 1-implement-and-rewrite-tests

Author: Ayogit1

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -16,6 +16,26 @@
 
 function getAngleType(angle) {
   // TODO: Implement this function
+  if (angle <= 0 || angle > 360) {
+    return "Invalid angle";
+  }
+
+  if (angle < 90) {
+    return "Acute angle";
+  } else if (angle === 90) {
+    return "Right angle";
+  } else if (angle < 180) {
+    return "Obtuse angle";
+  } else if (angle === 180) {
+    return "Straight angle";
+  } else if (angle < 360) {
+    return "Reflex angle";
+  } else if (angle === 360) {
+
+    return "Full rotation";
+  }
+
+  return "Invalid angle";
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -35,3 +55,12 @@ function assertEquals(actualOutput, targetOutput) {
 // Example: Identify Right Angles
 const right = getAngleType(90);
 assertEquals(right, "Right angle");
+
+// Test cases
+assertEquals(getAngleType(45), "Acute angle");
+assertEquals(getAngleType(90), "Right angle");
+assertEquals(getAngleType(120), "Obtuse angle");
+assertEquals(getAngleType(180), "Straight angle");
+assertEquals(getAngleType(270), "Reflex angle");
+assertEquals(getAngleType(0), "Invalid angle");
+assertEquals(getAngleType(400), "Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,6 +12,11 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
+  if (denominator === 0) {
+    return false;
+  }
+  // Proper fractions must be positive
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -31,3 +36,19 @@ function assertEquals(actualOutput, targetOutput) {
 
 // Example: 1/2 is a proper fraction
 assertEquals(isProperFraction(1, 2), true);
+
+
+assertEquals(isProperFraction(-1, 3), true);   // Negative numerator
+assertEquals(isProperFraction(1, -3), true);   // Negative denominator
+assertEquals(isProperFraction(0, 5), true);    // Zero numerator
+
+// Improper Fractions / Invalid
+assertEquals(isProperFraction(2, 1), false);   // Numerator > Denominator
+assertEquals(isProperFraction(1, 1), false);   // Numerator == Denominator
+assertEquals(isProperFraction(1, 0), false);   // Zero denominator
+assertEquals(isProperFraction(5, 5), false);   // Equal
+// --- ERROR CASES ---
+try {
+  isProperFraction(1, 0);
+  console.error("Error was not thrown for denominator = 0");
+} catch (e) { }

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -23,6 +23,43 @@
 
 function getCardValue(card) {
   // TODO: Implement this function
+  if (typeof card !== "string") {
+    throw new Error("Invalid card: must be a string");
+  }
+  if (typeof card !== "string") {
+    throw new Error("Invalid card: must be a string");
+  }
+
+  // Valid suits
+  const suits = ["♠", "♥", "♦", "♣"];
+
+  // Extract suit (last character)
+  const suit = card.slice(-1);
+  if (!suits.includes(suit)) {
+    throw new Error("Invalid card: unknown suit");
+  }
+
+  // Extract rank (everything except last character)
+  const rank = card.slice(0, -1);
+
+  const rankValues = {
+    A: 11,
+    J: 10,
+    Q: 10,
+    K: 10
+  };
+
+  if (rankValues[rank]) {
+    return rankValues[rank];
+  }
+
+  // Check numeric ranks 2–10
+  const num = Number(rank);
+  if (num >= 2 && num <= 10) {
+    return num;
+  }
+
+  throw new Error("Invalid card: unknown rank");
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -41,12 +78,69 @@ function assertEquals(actualOutput, targetOutput) {
 // Examples:
 assertEquals(getCardValue("9♠"), 9);
 
+assertEquals(getCardValue("9♠"), 9);
+assertEquals(getCardValue("A♥"), 11);
+assertEquals(getCardValue("10♦"), 10);
+assertEquals(getCardValue("K♣"), 10);
 // Handling invalid cards
 try {
   getCardValue("invalid");
 
   // This line will not be reached if an error is thrown as expected
   console.error("Error was not thrown for invalid card");
-} catch (e) {}
+} catch (e) { }
 
 // What other invalid card cases can you think of?
+
+try {
+  getCardValue("A?");
+  console.error("Error was not thrown for invalid suit");
+} catch (e) { }
+
+// Invalid rank: too small
+try {
+  getCardValue("1♠");
+  console.error("Error was not thrown for invalid rank 1");
+} catch (e) { }
+
+// Invalid rank: too large
+try {
+  getCardValue("11♣");
+  console.error("Error was not thrown for invalid rank 11");
+} catch (e) { }
+
+// Missing suit
+try {
+  getCardValue("A");
+  console.error("Error was not thrown for missing suit");
+} catch (e) { }
+
+// Missing rank
+try {
+  getCardValue("♠");
+  console.error("Error was not thrown for missing rank");
+} catch (e) { }
+
+// Empty string
+try {
+  getCardValue("");
+  console.error("Error was not thrown for empty string");
+} catch (e) { }
+
+// Non-string input
+try {
+  getCardValue(42);
+  console.error("Error was not thrown for non-string input");
+} catch (e) { }
+
+// Rank with extra characters
+try {
+  getCardValue("AAA♠");
+  console.error("Error was not thrown for malformed rank");
+} catch (e) { }
+
+// Suit in the wrong position
+try {
+  getCardValue("♠A");
+  console.error("Error was not thrown for reversed card format");
+} catch (e) { }

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -5,16 +5,42 @@ const getAngleType = require("../implement/1-get-angle-type");
 // TODO: Write tests in Jest syntax to cover all cases/outcomes,
 // including boundary and invalid cases.
 
-// Case 1: Acute angles
-test(`should return "Acute angle" when (0 < angle < 90)`, () => {
-  // Test various acute angles, including boundary cases
-  expect(getAngleType(1)).toEqual("Acute angle");
-  expect(getAngleType(45)).toEqual("Acute angle");
-  expect(getAngleType(89)).toEqual("Acute angle");
-});
+describe("getAngleType", () => {
+  // Case 1: Acute
+  test('should return "Acute angle" when (0 < angle < 90)', () => {
+    expect(getAngleType(1)).toBe("Acute angle");
+    expect(getAngleType(45)).toBe("Acute angle");
+    expect(getAngleType(89)).toBe("Acute angle");
+  });
 
-// Case 2: Right angle
-// Case 3: Obtuse angles
-// Case 4: Straight angle
-// Case 5: Reflex angles
-// Case 6: Invalid angles
+  // Case 2: Right angle
+  test('should return "Right angle" for exactly 90', () => {
+    expect(getAngleType(90)).toBe("Right angle");
+  });
+
+  // Case 3: Obtuse angles
+  test('should return "Obtuse angle" when (90 < angle < 180)', () => {
+    expect(getAngleType(91)).toBe("Obtuse angle");
+    expect(getAngleType(135)).toBe("Obtuse angle");
+    expect(getAngleType(179)).toBe("Obtuse angle");
+  });
+
+  // Case 4: Straight angle
+  test('should return "Straight angle" for exactly 180', () => {
+    expect(getAngleType(180)).toBe("Straight angle");
+  });
+
+  // Case 5: Reflex angles
+  test('should return "Reflex angle" when (180 < angle < 360)', () => {
+    expect(getAngleType(181)).toBe("Reflex angle");
+    expect(getAngleType(270)).toBe("Reflex angle");
+    expect(getAngleType(359)).toBe("Reflex angle");
+  });
+
+  // Case 6: Invalid angles
+  test('should return "Invalid angle" for values out of range', () => {
+    expect(getAngleType(0)).toBe("Invalid angle");
+    expect(getAngleType(-10)).toBe("Invalid angle");
+    expect(getAngleType(361)).toBe("Invalid angle");
+  });
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,3 +8,32 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+describe("isProperFraction", () => {
+  test("returns true for standard proper fractions", () => {
+    expect(isProperFraction(1, 2)).toBe(true);
+    expect(isProperFraction(2, 5)).toBe(true);
+  });
+
+  test("returns true for negative proper fractions", () => {
+    expect(isProperFraction(-1, 3)).toBe(true);
+    expect(isProperFraction(1, -3)).toBe(true);
+    expect(isProperFraction(-2, -5)).toBe(true);
+  });
+
+  test("returns false for improper fractions (n >= d)", () => {
+    expect(isProperFraction(3, 2)).toBe(false);
+    expect(isProperFraction(1, 1)).toBe(false);
+    expect(isProperFraction(-5, 2)).toBe(false);
+  });
+
+  test("returns true when numerator is zero (if denominator is non-zero)", () => {
+    expect(isProperFraction(0, 5)).toBe(true);
+    expect(isProperFraction(0, -1)).toBe(true);
+  });
+
+  test("returns false when denominator is zero", () => {
+    expect(isProperFraction(1, 0)).toBe(false);
+    expect(isProperFraction(0, 0)).toBe(false);
+  });
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -18,3 +18,69 @@ test(`Should return 11 when given an ace card`, () => {
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
 
+// Case 1: Ace (A)
+//
+describe("Ace cards", () => {
+  test("returns 11 for any Ace", () => {
+    expect(getCardValue("A♠")).toBe(11);
+    expect(getCardValue("A♥")).toBe(11);
+    expect(getCardValue("A♦")).toBe(11);
+    expect(getCardValue("A♣")).toBe(11);
+  });
+});
+
+//
+// Case 2: Number Cards (2–10)
+//
+describe("Number cards", () => {
+  test("returns correct numeric values for 2–10", () => {
+    expect(getCardValue("2♠")).toBe(2);
+    expect(getCardValue("5♥")).toBe(5);
+    expect(getCardValue("9♦")).toBe(9);
+    expect(getCardValue("10♣")).toBe(10);
+  });
+});
+
+//
+// Case 3: Face Cards (J, Q, K)
+//
+describe("Face cards", () => {
+  test("returns 10 for J, Q, K", () => {
+    expect(getCardValue("J♠")).toBe(10);
+    expect(getCardValue("Q♥")).toBe(10);
+    expect(getCardValue("K♦")).toBe(10);
+  });
+});
+
+//
+// Case 4: Invalid Cards
+//
+describe("Invalid cards", () => {
+  test("throws error for invalid rank", () => {
+    expect(() => getCardValue("1♠")).toThrow();
+    expect(() => getCardValue("11♣")).toThrow();
+    expect(() => getCardValue("Z♦")).toThrow();
+  });
+
+  test("throws error for invalid suit", () => {
+    expect(() => getCardValue("A?")).toThrow();
+    expect(() => getCardValue("10X")).toThrow();
+  });
+
+  test("throws error for missing suit or rank", () => {
+    expect(() => getCardValue("A")).toThrow();
+    expect(() => getCardValue("♠")).toThrow();
+    expect(() => getCardValue("")).toThrow();
+  });
+
+  test("throws error for non-string input", () => {
+    expect(() => getCardValue(123)).toThrow();
+    expect(() => getCardValue(null)).toThrow();
+    expect(() => getCardValue(undefined)).toThrow();
+  });
+
+  test("throws error for malformed multi-character ranks", () => {
+    expect(() => getCardValue("AA♠")).toThrow();
+    expect(() => getCardValue("A10♣")).toThrow();
+  });
+});