This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
NW6 | Fikret Ellek | JS2 Module | [TECH ED] Build todo-list app | WEEK-4 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2024 17:27
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
musayuksel
reviewed
Jan 29, 2024
| for (const todo of todos) { | ||
| const toDoListElement = document.createElement("li"); | ||
| toDoListElement.innerText = todo.task; | ||
| toDoListElement.classList.add(todo.task.replaceAll(" ", "-")); |
There was a problem hiding this comment.
This is a really handy way that every class name is one-of-a-kind :) Just keep in mind, if you add the same todo twice, it might behave differently
| deleteBtn.innerText = "Delete"; | ||
| deleteBtn.classList.add("todo-btn"); | ||
| deleteBtn.classList.add("delete-btn"); | ||
|
|
There was a problem hiding this comment.
Your code is well-structured and easy to understand @fikretellek . Great job!
Comment on lines
+30
to
+33
| span.appendChild(doneBtn); | ||
| span.appendChild(deleteBtn); | ||
| toDoListElement.appendChild(span); | ||
| list.appendChild(toDoListElement); |
There was a problem hiding this comment.
Awesome job here!!!! You'll learn much about DOM manipulation in the other modules, but you already follow the best practices, which is to prepare everything with JS and then add one thing to the DOM if possible. You absolutely smashed it.
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.