This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London 10 | Shahid Amin | JavaScript-Core-1-Coursework-Week3 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment to show the stages of working - This needs to be put in a function
VicJerUk
suggested changes
Apr 20, 2023
| @@ -21,7 +21,7 @@ function sayHello() { | |||
|
|
|||
| let hello = sayHello(); | |||
| console.log(hello); | |||
|
|
|||
| //There is no value passed to the function sayHello | |||
There was a problem hiding this comment.
Good, but not every function will have parameters. There's something missing inside the function sayHello for it not to be undefined. Can you spot what it is?
| let numbers = []; // add numbers from 1 to 10 into this array | ||
| let mentors; // Create an array with the names of the mentors: Daniel, Irina and Rares | ||
| let numbers = [1,2,3,4,5,6,7,8,9,10]; // add numbers from 1 to 10 into this array | ||
| let mentors = ["Daniel", "Irina", "Rares"]; // Create an array with the names of the mentors: Daniel, Irina and Rares | ||
|
|
| } | ||
|
|
||
| function last(arr) { | ||
| return; // complete this statement | ||
| return arr[arr.length - 1]; ; // complete this statement |
Comment on lines
+29
to
+33
| AGES.forEach(k => { | ||
| WRITERS.forEach(i => { | ||
| console.log(i + " is " + k + " years old") | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This doesn't look correct. Currently, it will say that every writer is 59,40,41,63 and 49 years old.
Comment on lines
20
to
+26
| // TODO | ||
| for (let dateOfBirth of BIRTHDAYS) { | ||
| let getMonth = dateOfBirth.split(' ')[0]; | ||
| if (getMonth === "July") { | ||
| return dateOfBirth; | ||
| } | ||
| } |
| @@ -5,7 +5,12 @@ | |||
| Implement the function below, which will return a new array containing only article titles which will fit. | |||
| */ | |||
| function potentialHeadlines(allArticleTitles) { | |||
| // TODO | |||
| const shortArticleTitles = []; | |||
| for (let articleTitle of allArticleTitles) { | |||
There was a problem hiding this comment.
Good job overall code inside the function will work correct but it doesn't seem to output a value. You are definitely missing something here.
| @@ -14,7 +19,16 @@ function potentialHeadlines(allArticleTitles) { | |||
| (you can assume words will always be seperated by a space) | |||
| */ | |||
| function titleWithFewestWords(allArticleTitles) { | |||
| // TODO | |||
| let fewestword = allArticleTitles[0].split(' ').length; | |||
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| let numbers = [1, 2, 3]; // Don't change this array literal declaration | |||
|
|
|||
| numbers[3] = numbers.push(4) | |||
| //The first value is 1??? | |||
There was a problem hiding this comment.
Good spot I'll forward that observation. But if it wasn't a 1 how would you change its value?
Comment on lines
+60
to
+72
| let arrayOfLengths = allArticleTitles.map(w => w.length); | ||
| console.log(arrayOfLengths) | ||
| let sumOfLengths = 0; | ||
| for (let i = 0; i < arrayOfLengths.length; i++) { | ||
| sumOfLengths += arrayOfLengths[i]; | ||
| console.log(sumOfLengths) | ||
| } | ||
|
|
||
| let sumOfArrayLengths = arrayOfLengths.length | ||
| console.log(sumOfArrayLengths) | ||
|
|
||
| let result = sumOfLengths/sumOfArrayLengths; | ||
| console.log(result) |
| averageprice.push(Math.round(average * 100) / 100); | ||
|
|
||
| } | ||
| return averageprice; |
There was a problem hiding this comment.
Good effort. Please make sure you indent your code correctly.
Functions for the radio station and the books completed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.