London10-Afsha-Hossain-JS-Core1-Coursework-Week3 #257

Afsha10 · 2023-03-08T22:51:12Z

No description provided.

Answered using comments why the outputs in the exercises are undefined

nsaimk · 2023-03-15T14:34:22Z

2-mandatory/2-financial-times.js

 function titleWithFewestWords(allArticleTitles) {
+    let shortestHeadline;


you could declare 'shortestHeadline' with const keyword instead let

I think shortestHeadline needs to be declared with let here as we are re-assigning a new value to it a few lines later.

SalihaPopal

Well done!

moneyinthesky · 2023-03-15T20:23:46Z

2-mandatory/1-weather-report.js

@@ -12,6 +12,12 @@
 */



Looks perfect 👍

moneyinthesky · 2023-03-15T20:24:22Z

2-mandatory/2-financial-times.js

@@ -5,6 +5,13 @@
    Implement the function below, which will return a new array containing only article titles which will fit.
 */


This look good!
For extra practice, can you try re-writing this using the filter array method?

SalihaPopal

Great job!

SalihaPopal · 2023-03-15T20:19:00Z

1-exercises/A-undefined/exercise.js

+
+// The output in the example below contains undefined because letters is an array with three elements, indexed from 0 to 2. 
+// When we try to access the element at index 3 (arr[3]), which is beyond the last index of the letters array, JavaScript returns undefined because there is no value at that index.
+


Nice explanation.

SalihaPopal · 2023-03-15T20:22:07Z

1-exercises/E-while-loop-with-array/exercise.js

+        if (BIRTHDAYS[i].startsWith("July"))
+        return BIRTHDAYS[i];
+        i++;
+    }
 }

 console.log(findFirstJulyBDay(BIRTHDAYS)); // should output "July 11th"


Nice work, consice and good.

moneyinthesky · 2023-03-15T20:27:14Z

2-mandatory/2-financial-times.js

@@ -13,25 +20,72 @@ function potentialHeadlines(allArticleTitles) {
    Implement the function below, which returns the title with the fewest words.
    (you can assume words will always be seperated by a space)
 */
+//        ["The", "three", "questions", "that", "dominate", "investment"]
+//         fewestNumberOfWords = articleSplitter.length;
+


This is a very good attempt 👍 One small improvement:

Could you try doing this without using let fewestNumberOfWords = 1000;

You could either leave it uninitialised and check for undefined in your loop.. Or you could maybe initialise to the numberOfWords of the first title in the list.

moneyinthesky · 2023-03-15T20:28:31Z

2-mandatory/2-financial-times.js

+// 1. We are getting array of string. We need to find if the string includes numbers.
+// 2. Once we find a number, we will put the string to the new array.
+// 3. We are going to return the new array. New array is string with numbers.
+


Very nice 👍

moneyinthesky · 2023-03-15T20:29:14Z

2-mandatory/2-financial-times.js

+// 2. We need to find the number of Article titles.
+// 3. We divide (total character) by (number of article titles).
+// 4. Round it up
+


Looks very good!

moneyinthesky · 2023-03-15T20:32:09Z

2-mandatory/3-stocks.js

+// 2. Divide the total price by the number of days i.e. 5
+
+
+


Very good variable names 😄
One question: Do you need to re-calculate the average each time through the loop? Maybe it's enough to just calculate the average once at the end?

moneyinthesky · 2023-03-15T20:33:27Z

2-mandatory/3-stocks.js

@@ -48,7 +64,13 @@ function getAveragePrices(closingPricesForAllStocks) {
    The price change value should be rounded to 2 decimal places, and should be a number (not a string)
 */


Nice!
One question: Will this code - closingPricesEachcompany[4] - closingPricesEachcompany[0] - still work if we have more than 5 prices in each array? Or less than 5 prices?
Can you think of how to make sure this works for any numbers of prices?

moneyinthesky · 2023-03-15T20:34:27Z

2-mandatory/3-stocks.js

+    //     }
+    //   }
+    //   arrayWithHighestValue.push(highestPrice);
+


This was a tough one!
Well done for completing it 👏

moneyinthesky · 2023-03-15T20:34:53Z

Great job on this coursework 👏

SalihaPopal · 2023-03-15T20:52:28Z

Thank you for your consideration and comments. I am going to apple what have you recommended me regarding some exercises.

We checked if we have an array that is the same length as the number of cities passed in.

Afsha10 added 4 commits March 6, 2023 00:28

Answered why the outputs in the exercises are undefined

017ff7b

Answered using comments why the outputs in the exercises are undefined

Completed exercise tasks B and C

a5138d4

Completed Exercises D and E and Mandatory task 1 and task 2

de3fc86

Completed the rest of the mandatory tasks

e32cf5f

nsaimk reviewed Mar 15, 2023

View reviewed changes

SalihaPopal reviewed Mar 15, 2023

View reviewed changes

moneyinthesky reviewed Mar 15, 2023

View reviewed changes

2-mandatory/1-weather-report.js

@@ -12,6 +12,12 @@

*/

Copy link

Contributor

moneyinthesky Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect 👍

moneyinthesky reviewed Mar 15, 2023

View reviewed changes

SalihaPopal reviewed Mar 15, 2023

View reviewed changes

moneyinthesky reviewed Mar 15, 2023

View reviewed changes

moneyinthesky added the reviewed A mentor has reviewed this code label Mar 15, 2023

Afsha10 added 2 commits March 22, 2023 00:20

Made some changes to exercises, mandatory and tried the extra part

0c6af51

Created a small test in weather report task

c1d359d

We checked if we have an array that is the same length as the number of cities passed in.

		function titleWithFewestWords(allArticleTitles) {
		let shortestHeadline;

		@@ -5,6 +5,13 @@
		Implement the function below, which will return a new array containing only article titles which will fit.
		*/


		// The output in the example below contains undefined because letters is an array with three elements, indexed from 0 to 2.
		// When we try to access the element at index 3 (arr[3]), which is beyond the last index of the letters array, JavaScript returns undefined because there is no value at that index.

		@@ -48,7 +64,13 @@ function getAveragePrices(closingPricesForAllStocks) {
		The price change value should be rounded to 2 decimal places, and should be a number (not a string)
		*/

Uh oh!

London10-Afsha-Hossain-JS-Core1-Coursework-Week3 #257

Are you sure you want to change the base?

London10-Afsha-Hossain-JS-Core1-Coursework-Week3 #257

Uh oh!

Conversation

Afsha10 commented Mar 8, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SalihaPopal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SalihaPopal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moneyinthesky commented Mar 15, 2023

Uh oh!

SalihaPopal commented Mar 15, 2023

Uh oh!

Uh oh!