This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Html css/week3/berhane #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rody-Kirwan
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Responsiveness work is good - probably need to tighten up in places.
Couple of notes:
- When creating a new PR for homework create a fresh branch - there are changes here from the last 2 weeks so difficult to see what to look at
- Always format code, remove commented code, whitespace etc before submitting (this makes it easier to read)
- Need to add some more styling / colour / pics etc.
| font-size: 1.17em; | ||
| margin-block-start: 1em; | ||
| margin-block-end: 1em; | ||
| margin-inline-start: 0px; |
There was a problem hiding this comment.
Prefer no unit when the value is zero. margin-inline-start: 0;
Won't break but is an industry standard :)
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| /*margin-bottom: 10px; |
| @@ -0,0 +1,266 @@ | |||
|
|
|||
There was a problem hiding this comment.
Try to keep spacing consistent through out the file. It makes it easier to read
Check for an extension on vscode that will format the file.
| <div class="image-carousel"><img src="" alt="">IMAGE CAROUSEL</div> | ||
| <div class="carousel-list"> | ||
| <ul class="carousel-item"> | ||
| <li><img src="" alt="">IMG1</li> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Week3 HTML-CSS-homework